-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic Excalidraw embed image Proof of Concept #1389
base: v4
Are you sure you want to change the base?
Conversation
Very cool, and very little code changes. Don't know if this helps, but i found this gist as an example of dark/light mode switching. I'm not familiar with this codebase, so I may be wrong. |
Thanks for the heads-up! I have updated the code for generic image as well, see below for a preview (mild epilepsy warning) Screencast.from.2024-09-23.20-11-38.webm |
Hi, I'm the author of the gist referenced by @jacobeverist, and I just wanted to point out that I have since improved that code and made it part of my Quartz website's repo. It has become the You can see the component in action here for example. Anyways, it works pretty well, but I still wasn't sufficiently happy with it which is why I never contributed it to the Quartz project:
I have documentend the code reasonably well I think, but proper user documentation still needs doing. Anyways, looking forward to see how you finish this up :). Nice work! |
Thanks for the input! I'm currently looking into reworking the markdown parser steps. I have some thoughts on how to incorporate your code, but the specifics might change a bit after said rework. Luckily, your implementation seems relatively simple to adapt. I'll keep you posted. |
Looking forward to this. One feature that will be really cool is the ability to support Obsidian Excalidraw plugin embeds (other notes in the vault). This will virtually transform quartz into an all-in-one documentation platform with mind mapping support |
Closes #1043
*.excalidraw.md