fix(layout): grid triage and regression #1440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
keep me posted. I can help with merging and testing out. Just migrated to 4.4.0 on another site. |
Most reported issues have been fixed. I hope to finalize my fixes for #1437 tomorrow. |
I believe all current issues have been addressed. I'm waiting for the fixes for #1437 to be verified, but otherwise ready for review. |
|
@aarnphm I encountered another issue related to the interaction between js and css when toggling explorer/table of contents. Last commit fixed the issue. Should be all done now. |
aarnphm
approved these changes
Sep 25, 2024
parkisutama
pushed a commit
to parkisutama/quartz
that referenced
this pull request
Sep 28, 2024
* fix(table of contents): multiple scrollbars (jackyzha0#1388) * fix(center): Main content mininum width (jackyzha0#1439) * fix(code block): Horizontal overflow fix (jackyzha0#1438, jackyzha0#1353) * WIP fix for ul/ol .overflow * Fix: restore former scrollbar behavior for overflow lists (jackyzha0#1437) * Fix: code block overflow-x * fix: Table of Content overflow (jackyzha0#1437) * Address feedback * Move max-height toggle from js to css
ChenghaoMou
pushed a commit
to ChenghaoMou/quartz
that referenced
this pull request
Oct 5, 2024
* fix(table of contents): multiple scrollbars (jackyzha0#1388) * fix(center): Main content mininum width (jackyzha0#1439) * fix(code block): Horizontal overflow fix (jackyzha0#1438, jackyzha0#1353) * WIP fix for ul/ol .overflow * Fix: restore former scrollbar behavior for overflow lists (jackyzha0#1437) * Fix: code block overflow-x * fix: Table of Content overflow (jackyzha0#1437) * Address feedback * Move max-height toggle from js to css
DronHazra
pushed a commit
to DronHazra/quartz
that referenced
this pull request
Oct 27, 2024
* fix(table of contents): multiple scrollbars (jackyzha0#1388) * fix(center): Main content mininum width (jackyzha0#1439) * fix(code block): Horizontal overflow fix (jackyzha0#1438, jackyzha0#1353) * WIP fix for ul/ol .overflow * Fix: restore former scrollbar behavior for overflow lists (jackyzha0#1437) * Fix: code block overflow-x * fix: Table of Content overflow (jackyzha0#1437) * Address feedback * Move max-height toggle from js to css
DronHazra
pushed a commit
to DronHazra/quartz
that referenced
this pull request
Oct 28, 2024
* fix(table of contents): multiple scrollbars (jackyzha0#1388) * fix(center): Main content mininum width (jackyzha0#1439) * fix(code block): Horizontal overflow fix (jackyzha0#1438, jackyzha0#1353) * WIP fix for ul/ol .overflow * Fix: restore former scrollbar behavior for overflow lists (jackyzha0#1437) * Fix: code block overflow-x * fix: Table of Content overflow (jackyzha0#1437) * Address feedback * Move max-height toggle from js to css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for problems that arise the coming days after the v4.4.0 grid layout rework.
I'll keep adding to this PR as new problems arise in the coming days.