Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(comments): add conditional display using frontmatter #1566

Open
wants to merge 5 commits into
base: v4
Choose a base branch
from
Open

feat(comments): add conditional display using frontmatter #1566

wants to merge 5 commits into from
+20 −1

Conversation

konstfish
Copy link
Contributor

Resolves #1534

This keeps the original behaviour of enabling comments on every page, but gives users the option to set respectFrontmatter in the comment options, which makes comments only render on pages with a true comments frontmatter attribute.

aarnphm
aarnphm approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny

quartz/components/Comments.tsx Outdated Show resolved Hide resolved
quartz/components/Comments.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saberzero1 saberzero1 saberzero1 left review comments

@aarnphm aarnphm aarnphm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable comments only on certain notes
3 participants
@konstfish @saberzero1 @aarnphm