Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove assets via globs to avoid volume mount lock #877

Merged
merged 7 commits into from
Feb 19, 2024
Merged

fix: remove assets via globs to avoid volume mount lock #877

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d793d6d
Fix docker volume lock issue by altering asset cleanup method
kon-foo Feb 17, 2024
9e7788a
Add fsOps utility for filesystem operations
kon-foo Feb 17, 2024
900f6c6
Use cleanDirectory in build process to fix volume lock issue
kon-foo Feb 17, 2024
12769fd
applied prettier
kon-foo Feb 17, 2024
9ffdc55
handle ENOENT error when output dir does not exist
kon-foo Feb 17, 2024
ef6c982
remove native function in favor of rimraf
kon-foo Feb 17, 2024
bc3b7b5
use path.join to concatenate paths
kon-foo Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions quartz/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ async function buildQuartz(argv: Argv, mut: Mutex, clientRefresh: () => void) {

const release = await mut.acquire()
perf.addEvent("clean")
await rimraf(output)
kon-foo marked this conversation as resolved.
Show resolved Hide resolved
await rimraf(path.join(output, "*"), { glob: true })
console.log(`Cleaned output directory \`${output}\` in ${perf.timeSince("clean")}`)

perf.addEvent("glob")
Expand Down Expand Up @@ -375,7 +375,7 @@ async function rebuildFromEntrypoint(

// TODO: we can probably traverse the link graph to figure out what's safe to delete here
// instead of just deleting everything
await rimraf(argv.output)
await rimraf(path.join(argv.output, ".*"), { glob: true })
await emitContent(ctx, filteredContent)
console.log(chalk.green(`Done rebuilding in ${perf.timeSince()}`))
} catch (err) {
Expand Down
Loading