Another attempt at fixing #543

src/lsp.cc

@@ -37,7 +37,7 @@ struct UriCache {
     // If we do not have the value in the cache, try to renormalize it.
     // Otherwise we will return paths with all lower-case letters which may
     // break vscode.
-    optional<AbsolutePath> normalized = NormalizePath(path.path);
+    optional<AbsolutePath> normalized = NormalizePath(path.path, true /*ensure_exists*/, false /*force_lower_on_windows*/);
     if (normalized)
       return normalized->path;
 

src/platform.h

@@ -27,7 +27,8 @@ void PlatformInit();
 AbsolutePath GetExecutablePath();
 AbsolutePath GetWorkingDirectory();
 optional<AbsolutePath> NormalizePath(const std::string& path,
-                                     bool ensure_exists = true);
+                                     bool ensure_exists = true,
+                                     bool force_lower_on_windows = true);
 
 // Creates a directory at |path|. Creates directories recursively if needed.
 void MakeDirectoryRecursive(const AbsolutePath& path);

src/platform_posix.cc

@@ -161,7 +161,8 @@ AbsolutePath GetWorkingDirectory() {
 }
 
 optional<AbsolutePath> NormalizePath(const std::string& path,
-                                     bool ensure_exists) {
+                                     bool ensure_exists,
+                                     bool force_lower_on_windows) {
   return RealPathNotExpandSymlink(path, ensure_exists);
 }
 

src/platform_win.cc

@@ -56,7 +56,8 @@ AbsolutePath GetWorkingDirectory() {
 }
 
 optional<AbsolutePath> NormalizePath(const std::string& path0,
-                                     bool ensure_exists) {
+                                     bool ensure_exists,
+                                     bool force_lower_on_windows) {
   // Requires Windows 8
   /*
   if (!PathCanonicalize(buffer, path.c_str()))
@@ -99,8 +100,10 @@ optional<AbsolutePath> NormalizePath(const std::string& path0,
   path[0] = toupper(path[0]);
   */
   // Make the path all lower-case, since windows is case-insensitive.
-  for (size_t i = 0; i < path.size(); ++i)
-    path[i] = (char)tolower(path[i]);
+  if (force_lower_on_windows) {
+    for (size_t i = 0; i < path.size(); ++i)
+      path[i] = (char)tolower(path[i]);
+  }
 
   // cquery assumes forward-slashes.
   std::replace(path.begin(), path.end(), '\\', '/');