Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Migrate] JS to TS #104

Merged
merged 7 commits into from
Sep 2, 2022
Merged

[Migrate] JS to TS #104

merged 7 commits into from
Sep 2, 2022

Conversation

jacobtyq
Copy link
Owner

@jacobtyq jacobtyq commented Sep 2, 2022

Motivation

The main motivation of this PR is to

  • Convert this project from JS to TS
  • Clean up imports and folder structure
  • Update dependencies

Other fixes

  • An issue with TypeError: Cannot convert undefined or null to object when the findAllByValue function hits a null object has been fixed
  • Update README

@jacobtyq jacobtyq self-assigned this Sep 2, 2022
@jacobtyq
Copy link
Owner Author

jacobtyq commented Sep 2, 2022

Since PR authors cannot approve their own PR, I'll be bypassing branch protection and merging this

@jacobtyq jacobtyq merged commit aee04fa into master Sep 2, 2022
@delete-merged-branch delete-merged-branch bot deleted the migrate/typescript branch September 2, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant