Add Maven Mojo to perform offline instrumentation #64

Godin · 2013-01-04T16:33:39Z

No description provided.

stephanenicolas · 2013-01-02T05:24:38Z

Where can we learn how to use Jacoco with offline instrumentation ? I would like to try it on an android project ?

Godin · 2013-01-02T08:22:32Z

Version 0.6.2 which supports offline instrumentation is still in development, so things can dramatically change and that's why there is no public and official information on how to do this. But if you want to do some experiments with trunk, then discussion in #58 might be interesting for you.

stephanenicolas · 2013-01-02T09:30:53Z

I don't feel confortable enough to start from scratch. But if you need someone to test the documentation when it is ready, please notify me.

Thx for your work,
Stéphane

Godin · 2013-01-02T09:32:01Z

Ok, cool! I'll keep this in mind.

Conflicts: org.jacoco.doc/docroot/doc/changes.html

Godin · 2013-01-11T16:12:44Z

@marchof Could you please review those changes?

marchof · 2013-01-12T04:46:35Z

@Godin I will have a closer look at it tomorrow!

marchof · 2013-01-13T08:46:55Z

org.jacoco.examples/build/pom-offline.xml

+      <version>4.10</version>
+      <scope>test</scope>
+    </dependency>
+    <dependency>


This is a important step to provide the agent runtime here. Should we add a comment?

Done in 309ab4c

marchof · 2013-01-13T08:52:31Z

@Godin I feel like we should add a warning like this to the offline goals (also for the Ant task). The problem is that people migrating from other tools will expect an instrumentation step and might actually use this without any reason.

Warning: The preferred way for code coverage analysis with JaCoCo is on-the-fly instrumentation. Offline instrumentation has several drawbacks and should only be used if a specific scenario explicitly requires this mode. Please consult documentation about offline instrumentation before using this mode.

marchof · 2013-01-13T08:53:59Z

@Godin Minor comment about wording: I used "offline instrumentation" in documentation in lower case, you use upper case spelling. As "on-the-fly" is also lowercase I would prefer the lower case spelling.

marchof · 2013-01-13T09:00:50Z

@Godin Is it possible and reasonable to have a single goal 'instrument' which does also the cleanup job? I.e. have this goal bound to two phases by default?

marchof · 2013-01-13T19:02:42Z

jacoco-maven-plugin/src/org/jacoco/maven/InstrumentMojo.java

+		try {
+			final FileFilter fileFilter = new FileFilter(this.getIncludes(),
+					this.getExcludes());
+			fileNames = FileUtils.getFileNames(classesDir,


@Godin Can we somehow avoid or suppress the Eclipse compiler warning here? I like warning free workspaces ;-)

Type safety: The expression of type List needs unchecked conversion to conform to List

Godin · 2013-01-14T08:43:11Z

@marchof Not possible to bind the same goal to two phases by default, moreover this separation is required for support of Android.

Warning about offline instrumentation looks like a good idea for me - should I add it?

The rest has been fixed.

marchof · 2013-01-14T10:10:21Z

@Godin Ok, please add the warning to the Maven goals, I'll add it to the Ant task on master.

Godin · 2013-01-14T12:19:37Z

@marchof Warning has been added, so can I merge?

marchof · 2013-01-14T12:21:17Z

@Godin Go for it ;-)

marchof · 2013-01-14T15:47:15Z

jacoco-maven-plugin/src/org/jacoco/maven/InstrumentMojo.java

+ * Performs offline instrumentation. Note that after execution of test you must
+ * restore original classes with help of "restore-instrumented-classes" goal.
+ * <p>
+ * <b>Warning:</b> The preferred way for code coverage analysis with JaCoCo is


@Godin Either we use the "strong" tag here or we need to extend the stylesheet. Currently the "b" markup gets lost.

@marchof Indeed - I'll change on "strong".

Add Maven Mojos to perform offline instrumentation

stephanenicolas · 2013-03-24T14:44:12Z

HI @Godin ,

this thread is a bit old now but your experiment with android helped me a lot to set up a unified code coverage for both robolectric and standard junit tests and get it displayed in a sonar dash board.

(see the Jacoco profile here : https://github.com/stephanenicolas/Quality-Tools-for-Android/blob/)

Robolectric are considered standard unit tests.
standard Android Junit tests are considered as standard integration tests.
This makes sense as Robolectric tests mock an android platform and can be considered more "unit" tests thant standard android tests because the latter needs a real android platform and relies on networking, disk, locale, etc.

I have been dreaming about that for almost a year now. Thanks a lot for offline instrumentation via jacoco :)

Do you think it would be possible to give better names to the test suites inside the widget, and even to add more test suites ? For instance I would like to add UI testing (black box testing) or monkey testing.

Godin · 2013-03-24T15:54:05Z

Hi @stephanenicolas ,

No need to write the same in several topics.

We are glad to hear that our work is useful for you.

What do you mean by "widget" ? If this is about Sonar, then this is not an appropriate place to discuss this.

stephanenicolas · 2013-03-25T06:50:57Z

Hi Evgeny,

you're right, I have been over enthusiastic about this :)
Sorry for having disturbed this forum. I just believed that people reaching
both threads might have been interested in this work.

By widget, I meant the Sonar widget, so you're right again, that's not the
place to talk about it.

Stéphane

2013/3/24 Evgeny Mandrikov notifications@github.com

Hi @stephanenicolas https://github.com/stephanenicolas ,

No need to write the same in several topics.

We are glad to hear that our work is useful for you.

What do you mean by "widget" ? If this is about Sonar, then this is not an
appropriate place to discuss this.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/64#issuecomment-15361176
.

Stéphane NICOLAS,
OCTO Technology
Développeur & Consultant Android / Java
..........................................................
50, Avenue des Champs-Elysées
75008 Paris
+33 (0)6.26.32.34.09
www.octo.com - blog.octo.com
www.usievents.com
...........................................................

stephanenicolas · 2013-10-29T10:01:25Z

Is offline instrumentation supposed to work for android with latest release
artifact ?

It looks like :
https://github.com/Godin/jacoco-experiments/blob/android/android/app.tests/pom.xml

is not working anymore with latest jacoco release. They only worked with
the snapshot 0.6.2-SNAPSHOT, but not afterwards.

Stéphane

Godin · 2013-10-29T11:29:44Z

@stephanenicolas It supposed to work, because there is no major changes on Maven Plugin side regarding this. In any case I suggest you to switch to Users Mailing List with better explanation of your problem.

ghost assigned Godin Dec 28, 2012

Godin mentioned this pull request Dec 28, 2012

Implementation for #4: Offline Instrumentation #58

Merged

Godin added 4 commits January 4, 2013 17:32

Add Maven Mojo to perform offline instrumentation

81c46ae

Update documentation

e6f41d4

Rename goal 'restore' into 'restore-instrumented-classes'

ccff137

Merge branch 'master' into issue-64

ee2d687

Conflicts: org.jacoco.doc/docroot/doc/changes.html

marchof reviewed Jan 13, 2013
View reviewed changes

Godin added 3 commits January 14, 2013 09:19

Resolve warnings in workspace

051ed37

Fix spelling

4c103bd

Add comment about jacocoagent.jar

309ab4c

Add warning about offline instrumentation

2f3c34d

Move warning into documentation

b12cc89

marchof reviewed Jan 14, 2013
View reviewed changes

Godin added 2 commits January 14, 2013 17:01

Fix Javadoc

3e28cb6

Plugin should not fail when classes not presented

341d860

Godin added a commit that referenced this pull request Jan 15, 2013

Merge pull request #64 from jacoco/issue-64

3c1cb3d

Add Maven Mojos to perform offline instrumentation

Godin merged commit 3c1cb3d into master Jan 15, 2013

Godin deleted the issue-64 branch January 15, 2013 10:00

jacoco locked and limited conversation to collaborators Jan 11, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Maven Mojo to perform offline instrumentation #64

Add Maven Mojo to perform offline instrumentation #64

Godin commented Jan 4, 2013

stephanenicolas commented Jan 2, 2013

Godin commented Jan 2, 2013

stephanenicolas commented Jan 2, 2013

Godin commented Jan 2, 2013

Godin commented Jan 11, 2013

marchof commented Jan 12, 2013

marchof Jan 13, 2013

Godin Jan 14, 2013

marchof commented Jan 13, 2013

marchof commented Jan 13, 2013

marchof commented Jan 13, 2013

marchof Jan 13, 2013

Godin commented Jan 14, 2013

marchof commented Jan 14, 2013

Godin commented Jan 14, 2013

marchof commented Jan 14, 2013

marchof Jan 14, 2013

Godin Jan 14, 2013

stephanenicolas commented Mar 24, 2013

Godin commented Mar 24, 2013

stephanenicolas commented Mar 25, 2013

stephanenicolas commented Oct 29, 2013

Godin commented Oct 29, 2013

Add Maven Mojo to perform offline instrumentation #64

Add Maven Mojo to perform offline instrumentation #64

Conversation

Godin commented Jan 4, 2013

stephanenicolas commented Jan 2, 2013

Godin commented Jan 2, 2013

stephanenicolas commented Jan 2, 2013

Godin commented Jan 2, 2013

Godin commented Jan 11, 2013

marchof commented Jan 12, 2013

marchof Jan 13, 2013

Choose a reason for hiding this comment

Godin Jan 14, 2013

Choose a reason for hiding this comment

marchof commented Jan 13, 2013

marchof commented Jan 13, 2013

marchof commented Jan 13, 2013

marchof Jan 13, 2013

Choose a reason for hiding this comment

Godin commented Jan 14, 2013

marchof commented Jan 14, 2013

Godin commented Jan 14, 2013

marchof commented Jan 14, 2013

marchof Jan 14, 2013

Choose a reason for hiding this comment

Godin Jan 14, 2013

Choose a reason for hiding this comment

stephanenicolas commented Mar 24, 2013

Godin commented Mar 24, 2013

stephanenicolas commented Mar 25, 2013

stephanenicolas commented Oct 29, 2013

Godin commented Oct 29, 2013