Fixes review changes requests for PR #1377

jacomyal · Oct 4, 2023 · 6b27c92 · 6b27c92
1 parent 699fc58
commit 6b27c92
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/src/rendering/webgl/programs/common/program.ts b/src/rendering/webgl/programs/common/program.ts
@@ -149,7 +149,7 @@ export abstract class Program<Uniform extends string = string> implements Abstra
             `Program: error while getting constant data (one vector has ${vector.length} items instead of ${constantAttributesItemsCount})`,
           );
 
-        constantData.push(...vector);
+        for (let j = 0; j < vector.length; j++) constantData.push(vector[j]);
       }
 
       this.STRIDE = this.ATTRIBUTES_ITEMS_COUNT;
@@ -224,12 +224,13 @@ export abstract class Program<Uniform extends string = string> implements Abstra
         gl.vertexAttribDivisor(location, 1);
       } else {
         const ext = gl.getExtension("ANGLE_instanced_arrays");
-        if (ext) ext.vertexAttribDivisorANGLE(location, 1);
+        if (!ext) throw new Error(`Program.bind: cannot retrieve WebGL extension "ANGLE_instanced_arrays"`);
+        ext.vertexAttribDivisorANGLE(location, 1);
       }
     }
 
     const sizeFactor = SIZE_FACTOR_PER_ATTRIBUTE_TYPE[attr.type];
-    if (typeof sizeFactor !== "number") throw new Error(`Program.bind: yet unsupported attribute type "${attr.type}"!`);
+    if (typeof sizeFactor !== "number") throw new Error(`Program.bind: yet unsupported attribute type "${attr.type}"`);
 
     return attr.size * sizeFactor;
   }

diff --git a/src/utils/index.ts b/src/utils/index.ts
@@ -430,15 +430,6 @@ export function extractPixel(gl: WebGLRenderingContext, x: number, y: number, ar
   return data;
 }
 
-/**
- * Function used to know whether given webgl context can use 32 bits indices.
- */
-export function canUse32BitsIndices(gl: WebGLRenderingContext): boolean {
-  const webgl2 = typeof WebGL2RenderingContext !== "undefined" && gl instanceof WebGL2RenderingContext;
-
-  return webgl2 || !!gl.getExtension("OES_element_index_uint");
-}
-
 /**
  * Check if the graph variable is a valid graph, and if sigma can render it.
  */