Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup quadtree space #1310

Closed
Yomguithereal opened this issue Nov 9, 2022 · 3 comments
Closed

Cleanup quadtree space #1310

Yomguithereal opened this issue Nov 9, 2022 · 3 comments

Comments

@Yomguithereal
Copy link
Collaborator

Currently, the quadtree indexes the framedGraph space, normalizing the sizes by the container width. This works but is conceptually weird and might cause issues with screens having a vertical aspect ratio.

We could use the nullCamera viewport space to index but there are two issues with this:

  1. Handling rotations
  2. We would be wasting some part of the x or y dimension (we already are actually), since we rescale the graph aspect ratio wrt viewport aspect ratio.
@stale
Copy link

stale bot commented Dec 19, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 19, 2022
@stale
Copy link

stale bot commented Jan 29, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 29, 2023
@jacomyal
Copy link
Owner

jacomyal commented Oct 3, 2023

Once #1382 is dealt with, this issue will be solved.

@jacomyal jacomyal closed this as completed Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants