Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added square, triangle and star node shapes. #78

Closed
wants to merge 4 commits into from
Closed

Added square, triangle and star node shapes. #78

wants to merge 4 commits into from

Conversation

timdcrain
Copy link

I've added triangles and stars to the squares added in 9b012de.

The squares are also re-positioned so that their center is at the x-y coordinate of the node.

Raibaz and others added 2 commits March 4, 2013 22:38
…by setting it to 'square'

Added triangle and star shapes.

Added missing semicolons, and filtered for in loops.
@alex-r-bigelow
Copy link

This is pretty cool! Lack of glyph support is something that's been really aggravating my users about Gephi.

To improve this a little, I tweaked the sigma.parseGexf.js to recognize the viz:shape tags, fixed a couple minor bugs, and added a 'diamond' (per gexf spec... all that's missing now for node viz support is the 'image' shape).

@timdcrain
Copy link
Author

Thanks! I added your fixes and the diamond shape. Thanks for catching those bugs!

@jacomyal
Copy link
Owner

I unfortunately cannot merge your PRs in the new version (some explanations here).
About the "custom node rendering" topic, here is how it will work in the new version.

@jacomyal jacomyal closed this Jan 11, 2014
A---- pushed a commit to A----/sigma.js that referenced this pull request Sep 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants