Skip to content

Commit

Permalink
Fixes #9 and #11 (#12)
Browse files Browse the repository at this point in the history
* Fix #9

Fix #9 with a "workaround".
Replacing Septmeber by September

* Fix #11

Workaround in order to Fix #11
Setting a 'hard' end date when date's are Null and 2014 SP3
  • Loading branch information
reharmsen authored and jadarnel27 committed Nov 27, 2018
1 parent 4cbfa43 commit 06b0bc1
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions src/GetSqlServerVersionInfo/Program.cs
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,17 @@ private static List<SqlServerBuild> GetSqlServerBuildsFromMicrosoftWebsite(
var extendedSupportEndDate = supportDate?.ExtendedSupportEndDate;
var servicePackSupportEndDate = supportDate?.ServicePackSupportEndDate;

// 2018-11-16: https://github.com/jadarnel27/SqlServerVersionScript/issues/11
// For some reason, somtimes a product is not listed on the support website.
// for instance SQL Server 2014 - Service Pack 3
// For now set support end date to '2014-09-07' as this is/was the End of Extended support for SQL 2014 SP2
if ((mainstreamSupportEndDate == null) && (extendedSupportEndDate == null) && (servicePackSupportEndDate == null) && (build.MajorVersionNumber == 12) && (build.ServicePack == "SP3"))
{
mainstreamSupportEndDate = new DateTime(2024, 9, 7);
extendedSupportEndDate = new DateTime(2024, 9, 7);
//continue;
}

build.SetSupportDates(mainstreamSupportEndDate, extendedSupportEndDate,
servicePackSupportEndDate);

Expand Down

0 comments on commit 06b0bc1

Please sign in to comment.