Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for the validity of the ssl fingerprint on every request #11

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

jadolg
Copy link
Owner

@jadolg jadolg commented Jan 27, 2023

What was done

  • Started using a session object from requests
  • Added _FingerprintAdapter to this session so it always checks the fingerprint

ToDo:

  • We need to think about how to enforce the use of this session object to avoid future issues
  • Add logging to warn the user about not using the fingerprint

outline_vpn/outline_vpn.py Fixed Show fixed Hide fixed
outline_vpn/outline_vpn.py Fixed Show fixed Hide fixed
outline_vpn/outline_vpn.py Fixed Show fixed Hide fixed
outline_vpn/outline_vpn.py Fixed Show fixed Hide fixed
outline_vpn/outline_vpn.py Fixed Show fixed Hide fixed
@jadolg jadolg force-pushed the check-ssl-fingerprint branch from 69ce077 to 4422a3b Compare January 27, 2023 20:15
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jadolg
Copy link
Owner Author

jadolg commented Jan 31, 2023

@p3ngu19z wdyt?

@jadolg jadolg merged commit 8710405 into main Feb 22, 2023
@jadolg jadolg deleted the check-ssl-fingerprint branch February 5, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant