Script recursion detection #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 3, 2016 11:42
…for more detail. - Removal of the $parentName parameter, as it's not used. - Checking whether the key of the commands array is a string/integer, string denotes a key => value array, which is likely to be a named function. - Removal of the recursion call as it didn't initially work, and it doesn't need to happen as we can't nest that far anyway.
|
The |
tompedals
approved these changes
Oct 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
$parentNamevariable isn't ever used, so the comparison on L86 would never returntrue.I've modified this to use the name of the script as the comparison against the value of the command minus the
@character.I've also removed the recursion of calling
hasInfiniteRecursionback on it's self as this throws warning because the value of$scripts[$command]is not a multi-dimensional array.Tests have not been modified because the check for infinite recursion is replicated within the ScriptRunner and the
hasInfiniteRecursionmethod isn't ever checked within any tests - might be a good idea to test this, though.