Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script Merging #32

Merged
merged 15 commits into from
Oct 4, 2016
Merged

Script Merging #32

merged 15 commits into from
Oct 4, 2016

Conversation

jedkirby
Copy link
Contributor

@jedkirby jedkirby commented Oct 4, 2016

Previously only scripts defined within the customer section of the meteor.json file were processed. This changes that to allow for all scripts to be runnable.

James Kirby added 15 commits October 4, 2016 11:13
Base extension to implement the default functionality of parsing conf…
167f1f9 
…igurations
Adding the config parsing method to be implemented
b95becd
Using the parse config method when loading the extension(s)
366b88a
Making all extensions extend the base extension to implement the defa…
d3cacfc 
…ult configuration parser
Making the scripts extension also extend the base extension
3ef5e59
Two futher extensions that need to extend the base extension
ac0f80e
Implementing the custom confirugation parser for the scripts
9118e4e
Abstracted the way the scripts are run to account for global/combined…
e0b4096 
… scripts
Better checking of the scripts existance prior to processing
698476b
Running the checks for global and combined at the point of run
c979479
Test cases also need to extend the base extension class
b2bd230
Renaming tests for global configurations and adding new tests for com…
0226b1b 
…bined
No need for the difference in arrays between global and combined
18735cf
Reverting the default answer to display when a script isn't found at all
af2f002
Small docblock change
16d1bd0
tompedals
tompedals approved these changes Oct 4, 2016
View reviewed changes
Copy link
Contributor

@tompedals tompedals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tompedals tompedals merged commit 3bdd7e4 into master Oct 4, 2016
@tompedals tompedals deleted the feature/script-merging branch October 4, 2016 14:12
@tompedals tompedals mentioned this pull request Oct 4, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tompedals tompedals tompedals approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jedkirby @tompedals