Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show default sampling strategy with per-operation sampling #346

Merged
merged 3 commits into from
Dec 31, 2019

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Dec 29, 2019

Short description of the changes

Signed-off-by: Yuri Shkuro <ys@uber.com>
@rutgerbrf
Copy link

rutgerbrf commented Dec 30, 2019

Looks good! Perhaps it should be noted that the default sampling probability is 0.1%, if no default strategy is configured (or maybe not, because of architecture.md, though that is about the client).

Yuri Shkuro added 2 commits December 31, 2019 13:34
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
@yurishkuro yurishkuro merged commit 6d9c016 into jaegertracing:master Dec 31, 2019
@yurishkuro
Copy link
Member Author

@rutgerbrf thanks for review, added a note about default prob.

@yurishkuro yurishkuro deleted the default-per-op-sampling branch February 11, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants