Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manual sidecar definition documentation and example #378

Merged
merged 2 commits into from
Mar 6, 2020
Merged

Add manual sidecar definition documentation and example #378

merged 2 commits into from
Mar 6, 2020

Conversation

ewohltman
Copy link
Contributor

Signed-off-by: Eric Wohltman eric.wohltman@gmail.com

Which problem is this PR solving?

Short description of the changes

  • This change includes updates for how to include the Jaeger Agent sidecar manually for controllers other than Deployments

Signed-off-by: Eric Wohltman <eric.wohltman@gmail.com>

```yaml
- name: jaeger-agent
image: jaegertracing/jaeger-agent:master
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is master the correct tag I should be using for next-release?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we publish master as latest. @pavolloffay can probably confirm.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found an example of an image tag for next-release using master here:

https://github.com/jaegertracing/documentation/blob/master/content/docs/next-release/operator.md#examples

And in the corresponding 1.17 documentation, it was changed to 1.17.0:

https://github.com/jaegertracing/documentation/blob/master/content/docs/1.17/operator.md#examples

So it would seem that master is the correct tag value for next-release 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use master for the operator, but latest for the Jaeger components in the main repo (collector, agent, query, all-in-one, ingester, ...)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification! Just updated next-release to point to latest for the agent example.

Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to verify the tag for the jaeger-agent image.

Signed-off-by: Eric Wohltman <eric.wohltman@gmail.com>
@jpkrohling jpkrohling merged commit 9744793 into jaegertracing:master Mar 6, 2020
@jpkrohling
Copy link
Contributor

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants