-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add manual sidecar definition documentation and example #378
Conversation
Signed-off-by: Eric Wohltman <eric.wohltman@gmail.com>
|
||
```yaml | ||
- name: jaeger-agent | ||
image: jaegertracing/jaeger-agent:master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is master
the correct tag I should be using for next-release
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we publish master as latest
. @pavolloffay can probably confirm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found an example of an image tag for next-release
using master
here:
And in the corresponding 1.17 documentation, it was changed to 1.17.0
:
So it would seem that master
is the correct tag value for next-release
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use master
for the operator, but latest
for the Jaeger components in the main repo (collector, agent, query, all-in-one, ingester, ...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification! Just updated next-release
to point to latest
for the agent example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just need to verify the tag for the jaeger-agent image.
Signed-off-by: Eric Wohltman <eric.wohltman@gmail.com>
Thanks for your contribution! |
Signed-off-by: Eric Wohltman eric.wohltman@gmail.com
Which problem is this PR solving?
Short description of the changes
Deployments