-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SPM docs to reflect support for spanmetrics connector #640
Update SPM docs to reflect support for spanmetrics connector #640
Conversation
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
✅ Deploy Preview for romantic-neumann-1959d7 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested much simpler banner text. Please make sure to run the dead links checker (I don't think it works reliably from CI)
content/docs/next-release/spm.md
Outdated
The [SpanMetrics Processor](https://github.com/jaegertracing/jaeger/blob/main/docker-compose/monitor/README.md#migrating-to-span-metrics-connector) | ||
is deprecated in favour of the [SpanMetrics Connector](https://github.com/jaegertracing/jaeger/blob/main/docker-compose/monitor/README.md#migrating-to-span-metrics-connector). | ||
|
||
Specifically for the SPM feature, Jaeger versions ≤ 1.45.0 will support Opentelemetry Collector versions ≤ 0.70.0. | ||
|
||
As a corollary, Jaeger versions ≥ 1.46.0 will support Opentelemetry Collector versions ≥ 0.71.0. | ||
|
||
For details on migrating your Jaeger components to use the metrics produced by the | ||
[SpanMetrics Connector](https://github.com/jaegertracing/jaeger/blob/main/docker-compose/monitor/README.md#migrating-to-span-metrics-connector) | ||
please refer to the [migration guide](https://github.com/jaegertracing/jaeger/blob/main/docker-compose/monitor/README.md#migrating-to-span-metrics-connector). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The [SpanMetrics Processor](https://github.com/jaegertracing/jaeger/blob/main/docker-compose/monitor/README.md#migrating-to-span-metrics-connector) | |
is deprecated in favour of the [SpanMetrics Connector](https://github.com/jaegertracing/jaeger/blob/main/docker-compose/monitor/README.md#migrating-to-span-metrics-connector). | |
Specifically for the SPM feature, Jaeger versions ≤ 1.45.0 will support Opentelemetry Collector versions ≤ 0.70.0. | |
As a corollary, Jaeger versions ≥ 1.46.0 will support Opentelemetry Collector versions ≥ 0.71.0. | |
For details on migrating your Jaeger components to use the metrics produced by the | |
[SpanMetrics Connector](https://github.com/jaegertracing/jaeger/blob/main/docker-compose/monitor/README.md#migrating-to-span-metrics-connector) | |
please refer to the [migration guide](https://github.com/jaegertracing/jaeger/blob/main/docker-compose/monitor/README.md#migrating-to-span-metrics-connector). | |
Starting with v1.46.0, Jaeger supports the OpenTelemetry [SpanMetrics Connector][spanmetrics-conn], which is replacing the deprecated [SpanMetrics Processor][spanmetrics]. Please refer to the [migration guide](https://github.com/jaegertracing/jaeger/blob/main/docker-compose/monitor/README.md#migrating-to-span-metrics-connector). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks a lot better, thanks! I intended to provide guidance for users who weren't ready to upgrade to jaeger 1.46.0, but I think it's safe to assume more users are happy to upgrade jaeger, given they're willing to upgrade OTEL.
Updated in faab703 and added back the spanmetrics
reference in: 7d76dbd.
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
Which problem is this PR solving?
Short description of the changes