Fix issues with Jaeger running on .NET Framework #213
Conversation
Signed-off-by: Kraemer, Benjamin <falco20019@hotmail.com>
| @@ -13,6 +16,10 @@ public class AutofacConfig | |||
|
|
|||
| static AutofacConfig() | |||
| { | |||
| // This is necessary to pick the correct sender, otherwise a NoopSender is used! | |||
There was a problem hiding this comment.
doesn't seem related to the PR directly, is this just an oversight from the previous resolver refactoring?
There was a problem hiding this comment.
Yep, oversight from when we split up the packages. Since most people either use the NetCore package for ASP.NET (which has it‘s own example over there) or directly the configure options as in the main readme, nobody recognized.
| @@ -30,10 +33,16 @@ public void ConfigureServices(IServiceCollection services) | |||
| // Adds the Jaeger Tracer. | |||
| services.AddSingleton<ITracer>(serviceProvider => | |||
| { | |||
| string serviceName = serviceProvider.GetRequiredService<IWebHostEnvironment>().ApplicationName; | |||
| var serviceName = serviceProvider.GetRequiredService<IWebHostEnvironment>().ApplicationName; | |||
| var loggerFactory = serviceProvider.GetRequiredService<ILoggerFactory>(); | |||
There was a problem hiding this comment.
just curious, if .net already has this mechanism of service providers, why did we need a custom SenderConfiguration.DefaultSenderResolver? Couldn't we register ThriftSenderFactory with service provider?
There was a problem hiding this comment.
That‘s only for ASP.NET (website stuff), but not for Desktop or Console applications. There are some dependency injection frameworks available, but I didn‘t want to force users to use one, since there is no gold standard.
Which problem is this PR solving?
Short description of the changes
ApacheThriftto 0.14Microsoft.Extensions.Logging.Abstractionsto 3.1