address comments

span.go

@@ -116,11 +116,11 @@ func (s *Span) LogFields(fields ...log.Field) {
 	if !s.context.IsSampled() {
 		return
 	}
-	s.logFieldsWithLock(fields...)
+	s.logFieldsNoLocking(fields...)
 }
 
 // this function should only be called while holding a Write lock
-func (s *Span) logFieldsWithLock(fields ...log.Field) {
+func (s *Span) logFieldsNoLocking(fields ...log.Field) {
 	lr := opentracing.LogRecord{
 		Fields:    fields,
 		Timestamp: time.Now(),
@@ -182,7 +182,7 @@ func (s *Span) SetBaggageItem(key, value string) opentracing.Span {
 		return s
 	}
 	// If sampled, record the baggage in the span
-	s.logFieldsWithLock(
+	s.logFieldsNoLocking(
 		log.String("event", "baggage"),
 		log.String("key", key),
 		log.String("value", value),

span_test.go

@@ -57,7 +57,7 @@ func assertBaggageRecords(t *testing.T, sp *Span, expected map[string]string) {
 		value := logRecord.Fields[2].Value().(string)
 
 		require.Contains(t, expected, key)
-		assert.Equal(t, value, expected[key])
+		assert.Equal(t, expected[key], value)
 	}
 }