This repository has been archived by the owner on May 23, 2024. It is now read-only.
Add limit on log records per span #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
approved these changes
Jan 12, 2020
|
please make sure |
The MaxLogsPerSpan option limits the number of logs in a Span. Events are dropped as necessary; a log in the finished span indicates how many were dropped. fixes jaegertracing#46 Almost copy of opentracing/basictracer-go@723bb40 Signed-off-by: Sokolov Yura <funny.falcon@gmail.com>
funny-falcon
force-pushed
the
span-logs-limit
branch
from
d8428ff
to
1ba6aea
Compare
|
Done |
Codecov Report
@@ Coverage Diff @@
## master #483 +/- ##
==========================================
+ Coverage 88.21% 88.29% +0.07%
==========================================
Files 59 59
Lines 3512 3553 +41
==========================================
+ Hits 3098 3137 +39
- Misses 302 304 +2
Partials 112 112
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MaxLogsPerSpan option limits the number of logs in a Span. Events are
dropped as necessary; a log in the finished span indicates how many were
dropped.
Resolves #46
Almost copy of opentracing/basictracer-go@723bb40