Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Increase UDP batch overhead to account for data loss metrics #488

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • Increase batch overhead constant to 70 to account for extra space occupied by data loss metrics

Signed-off-by: Yuri Shkuro <ys@uber.com>
@codecov
Copy link

codecov bot commented Jan 16, 2020

Codecov Report

Merging #488 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #488   +/-   ##
=======================================
  Coverage   88.43%   88.43%           
=======================================
  Files          59       59           
  Lines        3581     3581           
=======================================
  Hits         3167     3167           
  Misses        303      303           
  Partials      111      111
Impacted Files Coverage Δ
transport_udp.go 97.29% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 100e8b7...4c730c6. Read the comment docs.

@yurishkuro yurishkuro merged commit 1db6ae6 into jaegertracing:master Jan 16, 2020
@yurishkuro yurishkuro deleted the fix-issue-486 branch January 16, 2020 21:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reporter creating batches bigger than UDP's max size
2 participants