Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Add a debug logging interface #503

Merged
merged 2 commits into from
Apr 21, 2020

Conversation

vprithvi
Copy link
Contributor

Relates to #501

  • Add a debug log interface so that the client may log more details when the supplied logger supports debug logging and is configured to log debug logs.
  • Add a debug log adapter that converts a standard logger to a debug logger if it satisfies the new interface. If it doesn't, debug logging is disabled.

Signed-off-by: Prithvi Raj <p.r@uber.com>
@codecov
Copy link

codecov bot commented Apr 21, 2020

Codecov Report

Merging #503 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #503      +/-   ##
==========================================
+ Coverage   88.43%   88.50%   +0.06%     
==========================================
  Files          59       59              
  Lines        3581     3600      +19     
==========================================
+ Hits         3167     3186      +19     
  Misses        303      303              
  Partials      111      111              
Impacted Files Coverage Δ
sampler_remote.go 82.35% <ø> (ø)
tracer.go 95.88% <ø> (ø)
log/logger.go 100.00% <100.00%> (ø)
log/zap/logger.go 100.00% <100.00%> (ø)
reporter_options.go 100.00% <100.00%> (ø)
sampler_remote_options.go 100.00% <100.00%> (ø)
tracer_options.go 79.10% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef8f5ed...95544e2. Read the comment docs.

log/zap/logger.go Outdated Show resolved Hide resolved
sampler_remote.go Outdated Show resolved Hide resolved
Signed-off-by: Prithvi Raj <p.r@uber.com>
@vprithvi vprithvi merged commit 5b28adb into jaegertracing:master Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants