This repository has been archived by the owner on May 23, 2024. It is now read-only.
Fix regression by handling nil logger correctly #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Verify that the logger is non-nil before logging Signed-off-by: Prithvi Raj <p.r@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #507 +/- ##
=======================================
Coverage 88.73% 88.74%
=======================================
Files 60 60
Lines 3782 3784 +2
=======================================
+ Hits 3356 3358 +2
Misses 309 309
Partials 117 117
Continue to review full report at Codecov.
|
yurishkuro
approved these changes
Apr 28, 2020
log/logger.go
Outdated
| @@ -117,8 +117,11 @@ func DebugLogAdapter(logger Logger) DebugLogger { | |||
| if debugLogger, ok := logger.(DebugLogger); ok { | |||
| return debugLogger | |||
| } | |||
| logger.Infof("debug logging disabled") | |||
| return debugDisabledLogAdapter{logger: logger} | |||
| if logger != nil { | |||
There was a problem hiding this comment.
It seems that nil check should come first (even if the cast works on nil).
Signed-off-by: Prithvi Raj <p.r@uber.com>
vprithvi
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nilloggers.DebugLoggingAdaptorto preserve old behaviorSigned-off-by: Prithvi Raj p.r@uber.com