Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Document how to encrypt travis secrets #744

Merged
merged 2 commits into from
Sep 14, 2020

Conversation

pavolloffay
Copy link
Member

@pavolloffay pavolloffay commented Sep 14, 2020

Resolves #740

cc) @yurishkuro

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #744 into master will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #744      +/-   ##
============================================
+ Coverage     88.92%   89.10%   +0.17%     
- Complexity      602      603       +1     
============================================
  Files            73       73              
  Lines          2257     2257              
  Branches        294      294              
============================================
+ Hits           2007     2011       +4     
+ Misses          159      155       -4     
  Partials         91       91              
Impacted Files Coverage Δ Complexity Δ
...ing/internal/samplers/RemoteControlledSampler.java 91.25% <0.00%> (-1.25%) 16.00% <0.00%> (-1.00%)
...gertracing/internal/reporters/LoggingReporter.java 90.90% <0.00%> (+9.09%) 5.00% <0.00%> (+1.00%)
...rtracing/internal/reporters/CompositeReporter.java 100.00% <0.00%> (+28.57%) 7.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9091516...814ce51. Read the comment docs.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@yurishkuro
Copy link
Member

Probably not related to this PR, but a flaky test related to 0-padding:

io.jaegertracing.zipkin.internal.V2SpanConverterTest > testConvertSpanWith128BitTraceId FAILED
    org.junit.ComparisonFailure: expected:<[]4530fcc74d879887070b...> but was:<[0]4530fcc74d879887070b...>
        at org.junit.Assert.assertEquals(Assert.java:115)
        at org.junit.Assert.assertEquals(Assert.java:144)
        at io.jaegertracing.zipkin.internal.V2SpanConverterTest.testConvertSpanWith128BitTraceId(V2SpanConverterTest.java:310)

Restarting build.

@yurishkuro yurishkuro merged commit 3296585 into jaegertracing:master Sep 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document release process credentials
2 participants