Skip to content
This repository has been archived by the owner on Jul 11, 2022. It is now read-only.

Introduce BaseReporter type #329

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

yurishkuro
Copy link
Member

Turns out we don't have a good type to use in type declarations in #328.

Signed-off-by: Yuri Shkuro <github@ysh.us>
@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #329 (82207fb) into master (948b37e) will increase coverage by 0.08%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
+ Coverage   95.43%   95.51%   +0.08%     
==========================================
  Files          25       25              
  Lines        1971     2030      +59     
  Branches      273      274       +1     
==========================================
+ Hits         1881     1939      +58     
- Misses         56       57       +1     
  Partials       34       34              
Impacted Files Coverage Δ
jaeger_client/reporter.py 92.72% <88.88%> (-0.32%) ⬇️
jaeger_client/rate_limiter.py 100.00% <0.00%> (ø)
jaeger_client/span_context.py 100.00% <0.00%> (ø)
jaeger_client/span.py 96.66% <0.00%> (+0.11%) ⬆️
jaeger_client/utils.py 90.32% <0.00%> (+0.15%) ⬆️
crossdock/server/endtoend.py 96.66% <0.00%> (+0.23%) ⬆️
jaeger_client/config.py 96.19% <0.00%> (+0.58%) ⬆️
crossdock/server/server.py 88.40% <0.00%> (+0.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 948b37e...82207fb. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant