Skip to content
This repository has been archived by the owner on May 18, 2020. It is now read-only.

Explain cassandra deployment limitations #26

Merged
merged 2 commits into from
Aug 7, 2017

Conversation

pavolloffay
Copy link
Member

@pavolloffay pavolloffay requested a review from jpkrohling August 3, 2017 20:40
README.md Outdated
@@ -32,7 +32,8 @@ Once everything is ready, `kubectl get service jaeger-query` tells you where to

### Persistent storage
Even though this template uses a stateful Cassandra, backing storage is set to `emptyDir`. It's more
appropriate to create a `PersistentVolumeClaim`/`PersistentVolume` and use it instead.
appropriate to create a `PersistentVolumeClaim`/`PersistentVolume` and use it instead. Note that this
Cassandra deployment does not support deleting pods or scaling down.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... or scaling down, as this might require administrative tasks that are dependent on the final deployment architecture.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, but not deployed instead of deployment?

Copy link
Collaborator

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'd just add a statement after saying that we don't support deleting/scaling down (see suggestion).

@pavolloffay pavolloffay merged commit 9105f18 into jaegertracing:master Aug 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants