Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DaemonSet started before deployment can't get collector IPs #1175

Closed
jpkrohling opened this issue Sep 1, 2020 · 1 comment · Fixed by #1176
Closed

DaemonSet started before deployment can't get collector IPs #1175

jpkrohling opened this issue Sep 1, 2020 · 1 comment · Fixed by #1176
Assignees
Labels
bug Something isn't working

Comments

@jpkrohling
Copy link
Contributor

Currently, we have daemonsets being created before services and deployments:

if err := r.applyDaemonSets(ctx, jaeger, str.DaemonSets()); err != nil {
return jaeger, tracing.HandleError(err, span)
}
// seems counter intuitive to have services created *before* deployments,
// but some resources used by deployments are created by services, such as TLS certs
// for the oauth proxy, if one is used
if err := r.applyServices(ctx, jaeger, str.Services()); err != nil {
return jaeger, tracing.HandleError(err, span)
}
if err := r.applyDeployments(ctx, jaeger, str.Deployments()); err != nil {
return jaeger, tracing.HandleError(err, span)
}

Depending on the timing, the daemonset's pod might be up and running before the deployment gets even created, so that the headless service won't get a chance to get its IP for at least one backing collector. This causes the daemonset to not find any IPs upon bootstrap. The grpc-go client will not attempt to do any DNS refreshes at all (or only after 30m?), turning the agent unusable in this scenario.

This might be related to grpc/grpc-go#3353, so, it might be worth also bumping gRPC for Jaeger itself.

@jpkrohling jpkrohling self-assigned this Sep 1, 2020
@ghost ghost added the needs-triage New issues, in need of classification label Sep 1, 2020
@jpkrohling jpkrohling added bug Something isn't working and removed needs-triage New issues, in need of classification labels Sep 1, 2020
@jpkrohling
Copy link
Contributor Author

cc @kevinearls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant