-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add elasticsearch storage date format config. #1325
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1325 +/- ##
=======================================
Coverage 88.23% 88.24%
=======================================
Files 100 100
Lines 6385 6387 +2
=======================================
+ Hits 5634 5636 +2
Misses 553 553
Partials 198 198
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable. @kevinearls, given that you are working closer with ES nowadays, could you please review this?
@sniperking1234, is this feature available at Jaeger already? |
@jpkrohling this depends on jaegertracing/jaeger#2637 and jaegertracing/spark-dependencies#101 @sniperking1234 After those two are merged I'd like to see an E2E test for this. You could either add a case to test/e2e/elasticsearch_test.go or modify one of the two test cases that use indices. |
What's the status of this PR? |
@jpkrohling The dependent commit is still awaiting review. jaegertracing/spark-dependencies#101 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We miss ES_INDEX_DATE_SEPARATOR
in the expected list.
https://github.com/jaegertracing/jaeger-operator/runs/7033393524?check_suite_focus=true#step:6:741
Signed-off-by: Chen Zhengwei <chenzhengwei@inspur.com> Signed-off-by: chen zhengwei <chenzhengwei@inspur.com>
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Chen Zhengwei chenzhengwei@inspur.com
Which problem is this PR solving?
Jaeger can customize the es date format.
Short description of the changes
Depends on: jaegertracing/jaeger#2637 jaegertracing/spark-dependencies#101