Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove common name label #1920

Merged
merged 3 commits into from
May 31, 2022

Conversation

frzifus
Copy link
Member

@frzifus frzifus commented May 30, 2022

Signed-off-by: Benedikt Bongartz bongartz@klimlive.de

Which problem is this PR solving?

Short description of the changes

  • remove previously introduced common label
  • use name=jaeger-operator to bypass the jaeger deployment webhook

cc @rubenvp8510

rubenvp8510
rubenvp8510 previously approved these changes May 30, 2022
Copy link
Collaborator

@rubenvp8510 rubenvp8510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rubenvp8510 rubenvp8510 enabled auto-merge (squash) May 30, 2022 19:52
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
auto-merge was automatically disabled May 30, 2022 21:09

Head branch was pushed to by a user without write access

@frzifus frzifus force-pushed the fix/operator_upgrade_#1870 branch from b9edd34 to 8285355 Compare May 30, 2022 21:09
@frzifus frzifus requested a review from rubenvp8510 May 30, 2022 21:10
@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #1920 (22d05bc) into main (f0e5d05) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1920   +/-   ##
=======================================
  Coverage   88.25%   88.25%           
=======================================
  Files         100      100           
  Lines        6303     6303           
=======================================
  Hits         5563     5563           
  Misses        543      543           
  Partials      197      197           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0e5d05...22d05bc. Read the comment docs.

@rubenvp8510 rubenvp8510 merged commit d7440c1 into jaegertracing:main May 31, 2022
@frzifus frzifus deleted the fix/operator_upgrade_#1870 branch May 31, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade from 1.32.0 to 1.33.0 fails
2 participants