Fix command to deploy the simplest operator

[geoand]

Signed-off-by: Georgios Andrianakis geoand@gmail.com

[jpkrohling]

This change is 

[codecov]

Codecov Report

Merging #34 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #34   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files          16       16           
  Lines         599      599           
=======================================
  Hits          594      594           
  Misses          5        5

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb91503...aeef23e. Read the comment docs.

[jpkrohling]

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @geoand)

---

CONTRIBUTING.adoc, line 52 at r2 (raw file):

[source,bash]
----
make build run

Calling build before run should not be required. Did you have problems when running run without build?

[geoand]

I did have a problem, since run attempts to invoke the built artifact (./_output/bin/jaeger-operator) which is not present if the project is not built beforehand.
Am I perhaps going about this the wrong way?

Thanks

[jpkrohling]

You are absolutely correct. I just checked the Makefile and it does call the binary. A previous version probably executed go run main.go instead, which is what got me confused. Would you try just changing the Makefile to do go run main.go start instead of calling the binary and see if that works? One thing that might break is the "version" command, but other than that, it should just work.

If it works, then I'd appreciate if you could open another PR with that change alone, leaving this one without the make build run part.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @geoand)

[geoand]

@jpkrohling Sure thing, on it :)

[geoand]

@jpkrohling I updated this PR to include the simplest CRD command fix and opened #35 to address the run goal fix

[jpkrohling]

Reviewed 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved