Use es-operator from 4.1 branch #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
pavolloffay
commented
Jul 17, 2019
| @kubectl apply -f https://raw.githubusercontent.com/openshift/elasticsearch-operator/release-${ES_OPERATOR_VERSION}/manifests/03-role-bindings.yaml | ||
| @kubectl apply -f https://raw.githubusercontent.com/openshift/elasticsearch-operator/release-${ES_OPERATOR_VERSION}/manifests/04-crd.yaml -n ${ES_OPERATOR_NAMESPACE} | ||
| @kubectl apply -f https://raw.githubusercontent.com/openshift/elasticsearch-operator/release-${ES_OPERATOR_VERSION}/manifests/05-deployment.yaml -n ${ES_OPERATOR_NAMESPACE} | ||
| @kubectl set image deployment/elasticsearch-operator elasticsearch-operator=quay.io/openshift/origin-elasticsearch-operator:${ES_OPERATOR_VERSION} -n ${ES_OPERATOR_NAMESPACE} |
There was a problem hiding this comment.
I like this more than sed, however this is not perfect either.
The manifest should have the correct version in the branch. I have submitted a PR for it openshift/elasticsearch-operator#175
Codecov Report
@@ Coverage Diff @@
## master #537 +/- ##
=======================================
Coverage 91.97% 91.97%
=======================================
Files 69 69
Lines 3501 3501
=======================================
Hits 3220 3220
Misses 196 196
Partials 85 85Continue to review full report at Codecov.
|
objectiser
approved these changes
Jul 18, 2019
|
thanks @objectiser. The es-operator deploys quite quickly it shouldn't cause problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #481
Replaces #535
On the team meeting we agreed to use pinned es-operator version to avoid breaking us.
Signed-off-by: Pavol Loffay ploffay@redhat.com