Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read the service account's namespace when POD_NAMESPACE is missing #722

Merged
merged 1 commit into from
Oct 25, 2019

Conversation

jpkrohling
Copy link
Contributor

Resolves #721
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling
Copy link
Contributor Author

@derXear, would you be able to give this one a try? Just change your operator.yaml to use the following image: quay.io/jpkroehling/jaeger-operator:721-Empty-POD_NAMESPACE

Copy link
Contributor

@objectiser objectiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to have some tests?

@jpkrohling
Copy link
Contributor Author

In theory yes, but this one here is part of the command, which is hard to test :-/

Copy link
Contributor

@objectiser objectiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok :)

@jpkrohling
Copy link
Contributor Author

I tested this manually myself, but would be good to have a confirmation from @derXear that this indeed fixes the reported problem.

@jpkrohling
Copy link
Contributor Author

@qlikcoe, @toomai, looks like you might have been affected by this as well: would you be open to help testing this fix here? Just update your operator.yaml to use the following image: quay.io/jpkroehling/jaeger-operator:721-Empty-POD_NAMESPACE. Your operator.yaml should not contain the POD_NAMESPACE env var, as this fix is about testing how the operator behaves in the absence of this env var.

@toomai
Copy link

toomai commented Oct 25, 2019

Hi @jpkrohling,

I was indeed affected by this issue. After setting the image to jaeger-operator:721-Empty-POD_NAMESPACE and removing the env variable from the deployment, everything runs fine. I see the message the POD_NAMESPACE env var isn't set, trying to determine it from the service account info and the operator deploys the Jaeger configuration.
You should note that I am not yet in a production environment but that shouldn't change anything

Thank you for you reactivity and your work

@jpkrohling
Copy link
Contributor Author

Thanks for the confirmation! I'm merging this one.

@jpkrohling jpkrohling merged commit 954a44e into jaegertracing:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to create a jaeger instances when POD_NAMESPACE is empty
3 participants