Optimize tree walk

Signed-off-by: ruben.vargas <ruben.vp8510@gmail.com>
jaegertracing · Feb 11, 2019 · 3d691f8 · 3d691f8
1 parent f66f737
commit 3d691f8
Showing 1 changed file with 13 additions and 2 deletions.
diff --git a/packages/jaeger-ui/src/utils/TreeNode.js b/packages/jaeger-ui/src/utils/TreeNode.js
@@ -83,7 +83,18 @@ export default class TreeNode {
   }
 
   walk(fn, depth = 0) {
-    TreeNode.iterFunction(fn, depth)(this);
-    this.children.forEach(child => child.walk(fn, depth + 1));
+    const nodeStack = [];
+    let actualDepth = depth;
+    nodeStack.push({ node: this, depth: actualDepth });
+    const pushChildren = n => nodeStack.push({ node: n, depth: actualDepth });
+    while (nodeStack.length) {
+      const { node, nodeDepth } = nodeStack.pop();
+      TreeNode.iterFunction(fn, nodeDepth)(node);
+      actualDepth++;
+      node.children
+        .slice()
+        .reverse()
+        .forEach(pushChildren);
+    }
   }
 }