Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deps]: Upgrade react-redux to 9.x #2530

Open
yurishkuro opened this issue Dec 26, 2024 · 3 comments · Fixed by #2537
Open

[Deps]: Upgrade react-redux to 9.x #2530

yurishkuro opened this issue Dec 26, 2024 · 3 comments · Fixed by #2537

Comments

@yurishkuro
Copy link
Member

This is automated attempt that failed due to breaking changes #2527

But overall not that many components use react-redux

$ grep -rn react-redux packages/
packages//jaeger-ui/package.json:79:    "react-redux": "^8.1.2",
packages//jaeger-ui/src/components/Monitor/ServicesView/index.tsx:24:import { connect } from 'react-redux';
packages//jaeger-ui/src/components/App/index.jsx:16:import { Provider } from 'react-redux';
packages//jaeger-ui/src/components/App/Page.tsx:19:import { connect } from 'react-redux';
packages//jaeger-ui/src/components/App/TopNav.tsx:19:import { connect } from 'react-redux';
packages//jaeger-ui/src/components/QualityMetrics/index.tsx:17:import { connect } from 'react-redux';
packages//jaeger-ui/src/components/common/UiFindInput.tsx:21:import { connect } from 'react-redux';
packages//jaeger-ui/src/components/DeepDependencies/index.tsx:19:import { connect } from 'react-redux';
packages//jaeger-ui/src/components/DeepDependencies/traces.tsx:20:import { connect } from 'react-redux';
packages//jaeger-ui/src/components/DeepDependencies/SidePanel/DetailsPanel.tsx:18:import { connect } from 'react-redux';
packages//jaeger-ui/src/components/DeepDependencies/Graph/DdgNodeContent/index.tsx:20:import { connect } from 'react-redux';
packages//jaeger-ui/src/components/TraceDiff/TraceDiffGraph/TraceDiffGraph.tsx:18:import { connect } from 'react-redux';
packages//jaeger-ui/src/components/TraceDiff/TraceDiff.tsx:17:import { connect } from 'react-redux';
packages//jaeger-ui/src/components/DependencyGraph/index.jsx:19:import { connect } from 'react-redux';
packages//jaeger-ui/src/components/TracePage/index.tsx:22:import { connect } from 'react-redux';
packages//jaeger-ui/src/components/TracePage/TraceTimelineViewer/index.tsx:16:import { connect } from 'react-redux';
packages//jaeger-ui/src/components/TracePage/TraceTimelineViewer/VirtualizedTraceView.tsx:17:import { connect } from 'react-redux';
packages//jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanTreeOffset.tsx:19:import { connect } from 'react-redux';
packages//jaeger-ui/src/components/SearchTracePage/SearchForm.jsx:26:import { connect } from 'react-redux';
packages//jaeger-ui/src/components/SearchTracePage/index.test.js:35:import { Provider } from 'react-redux';
packages//jaeger-ui/src/components/SearchTracePage/index.jsx:20:import { connect } from 'react-redux';
@kunal-511
Copy link

@yurishkuro Is this issue still open for resolution?

@yurishkuro
Copy link
Member Author

Yes, feel free to try it.

@yurishkuro
Copy link
Member Author

yurishkuro commented Jan 5, 2025

Reverted in #2553

Explanation: #2542 (comment)

Booked another issue to remove redux-form #2556

@yurishkuro yurishkuro reopened this Jan 5, 2025
yurishkuro pushed a commit that referenced this issue Jan 5, 2025
Reverts #2537
Reason:
#2542 (comment)
Part of #2530

---------

Signed-off-by: Hariom Gupta <guptahariom03082003@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants