-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make width of left column adjustable in trace detail view #63
Comments
there should be a tooltip too |
My two cents: changeable width with more obvious truncation and a tooltip seems a more usual/usable choice here than scrolling horizontally within such a column (per #62). By "obvious" I mean using an ellipsis so it reads more like "serviceName reallyLongEndpoi...", or at worst "reallyLongServi..." I suppose? |
I agree, we should not make it scrollable, it's just bad usability. I'd start with ellipsis and tooltip, and if people still complain revisit making the width adjustable (unless it's easy to do then do both). I suggest we close #62 |
Thanks @jcorbin, @yurishkuro for the comments. The ellipsis has been shown with truncated text (currently in master) and the absence is a regression, which is now resolved in the branch I'm working on. Thanks for pointing it out 👍 In PR #53, I've added the full service and operation as a tooltip via the Choosing between the left column being scrollable vs adjustable, I agree, adjustable is better. But, both is better still, so I vote for that with the caveat of seeing where things land when shifting to react-virtualized. |
I'm +1 on expanding the text on mouseover rather than a classic tooltip, primarily because that then allows the user to easily select and copy the full name. I'm still not supportive of adding (even more?) scrollable sub-regions to an already busy visualization like this. To me it's a similar UX sin to nesting and proliferation of tabs. That said, it's not a hill I'm looking to die on, so if you feel strongly that scrolling is a good thing here, I'll wait to see it before final judgement ;-) |
Re expanding text on mouse over: Sounds good to me. @jcorbin - Re scrollbars: To me not having them for the left column seems like a massive omission. We can remove them if they seem sinful when / if added, though. |
* Fix #63 Left column adjustable in trace detail * Simplify span-name column drag code * Remove unused hint styling * Trace view Loading indicator, handle next trace * Flow for remaining TraceTimelineViewer components * Use lodash get to simplify property access
* Fix jaegertracing#63 Left column adjustable in trace detail * Simplify span-name column drag code * Remove unused hint styling * Trace view Loading indicator, handle next trace * Flow for remaining TraceTimelineViewer components * Use lodash get to simplify property access Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
The width of the left column in the trace detail view can be made adjustable to accommodate deeply nested spans, e.g. the same way the width of a column in a table can be adjusted.
The text was updated successfully, but these errors were encountered: