Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade many dependencies #1001

Merged
merged 95 commits into from
Oct 20, 2022
Merged

Upgrade many dependencies #1001

merged 95 commits into from
Oct 20, 2022

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Oct 20, 2022 •
edited
Loading

Which problem is this PR solving?

  • This is upgrading all possible dependencies without breaking build and tests

NB : I have not done any integration tests, only those actually provided

Please squash the commits

@codecov
Copy link

codecov bot commented Oct 20, 2022 •
edited
Loading

Codecov Report

Base: 95.35% // Head: 95.35% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (18fd3fe) compared to base (ce10d33).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1001   +/-   ##
=======================================
  Coverage   95.35%   95.35%           
=======================================
  Files         243      243           
  Lines        7560     7561    +1     
  Branches     1895     1895           
=======================================
+ Hits         7209     7210    +1     
  Misses        344      344           
  Partials        7        7
Impacted Files Coverage Δ
...aeger-ui/src/actions/path-agnostic-decorations.tsx 97.82% <0.00%> (-2.18%) ⬇️
...mponents/TracePage/TraceStatistics/tableValues.tsx 95.17% <0.00%> (-0.35%) ⬇️
...nents/TracePage/TraceTimelineViewer/SpanBarRow.tsx 100.00% <0.00%> (+5.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

yurishkuro
yurishkuro reviewed Oct 20, 2022
View reviewed changes
.eslintrc.js Outdated
@@ -44,7 +44,7 @@ module.exports = {
],
rules: {
/* general */
'arrow-parens': [1, 'as-needed'],
'arrow-parens': [1, 'always'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like this change is responsible for the most styling noise in the PR, what was the motivation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The responsible is prettier v2. I rollbacked it’s upgrade and git back to the initial configuration.

@yurishkuro
Copy link
Member

Thanks for taking on this issue!

After looking at the diff, here's my suggestion on how to move this forward:

  • I suggest removing all pure styling changes. The PR is currently nearly impossible to review in GH Web UI, it crumbles. But more importantly, the styling changes obscure the real code changes that may have been necessary due to dependency upgrades. This is just a bad practice to combine such changes.
  • I would like to understand the scope of the change. The title says "all deps", but I see that typescript version is still 3.x (dependabot has been trying to upgrade to 4.x for some time, there are some things that are breaking). And the other major one is react, which still seems to be at "react": "^16.3.2".

mmorel-35 and others added 24 commits October 20, 2022 17:20
@mmorel-35
Update package.json
00d0245 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
Create run-commit.yml
5cf97b8 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
Commit from GitHub Actions (Run and commit)
4969ab1 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
Update dependabot.yml
1f9368c 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@dependabot @mmorel-35
Bump style-loader from 0.23.1 to 3.3.1
5967f4d 
Bumps [style-loader](https://github.com/webpack-contrib/style-loader) from 0.23.1 to 3.3.1.
- [Release notes](https://github.com/webpack-contrib/style-loader/releases)
- [Changelog](https://github.com/webpack-contrib/style-loader/blob/master/CHANGELOG.md)
- [Commits](webpack-contrib/style-loader@v0.23.1...v3.3.1)

---
updated-dependencies:
- dependency-name: style-loader
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@dependabot @mmorel-35
Bump @babel/cli from 7.13.14 to 7.19.3
826cd14 
Bumps [@babel/cli](https://github.com/babel/babel/tree/HEAD/packages/babel-cli) from 7.13.14 to 7.19.3.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.19.3/packages/babel-cli)

---
updated-dependencies:
- dependency-name: "@babel/cli"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@dependabot @mmorel-35
Bump http-proxy-middleware from 0.19.1 to 2.0.6
c80a910 
Bumps [http-proxy-middleware](https://github.com/chimurai/http-proxy-middleware) from 0.19.1 to 2.0.6.
- [Release notes](https://github.com/chimurai/http-proxy-middleware/releases)
- [Changelog](https://github.com/chimurai/http-proxy-middleware/blob/master/CHANGELOG.md)
- [Commits](chimurai/http-proxy-middleware@v0.19.1...v2.0.6)

---
updated-dependencies:
- dependency-name: http-proxy-middleware
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@dependabot @mmorel-35
Bump @babel/core from 7.3.4 to 7.19.3
073f0dd 
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.3.4 to 7.19.3.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.19.3/packages/babel-core)

---
updated-dependencies:
- dependency-name: "@babel/core"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
Update dependabot.yml
3c4659e 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@dependabot @mmorel-35
Bump worker-loader from 2.0.0 to 3.0.8
8375366 
* Bump worker-loader from 2.0.0 to 3.0.8

Bumps [worker-loader](https://github.com/webpack-contrib/worker-loader) from 2.0.0 to 3.0.8.
- [Release notes](https://github.com/webpack-contrib/worker-loader/releases)
- [Changelog](https://github.com/webpack-contrib/worker-loader/blob/master/CHANGELOG.md)
- [Commits](webpack-contrib/worker-loader@v2.0.0...v3.0.8)

---
updated-dependencies:
- dependency-name: worker-loader
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update webpack-factory.js

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@dependabot @mmorel-35
Bump @babel/preset-env from 7.3.4 to 7.19.4
283904a 
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.3.4 to 7.19.4.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.19.4/packages/babel-preset-env)

---
updated-dependencies:
- dependency-name: "@babel/preset-env"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@dependabot @mmorel-35
Bump enzyme from 3.9.0 to 3.11.0
fb1b5ae 
Bumps [enzyme](https://github.com/airbnb/enzyme/tree/HEAD/packages/enzyme) from 3.9.0 to 3.11.0.
- [Release notes](https://github.com/airbnb/enzyme/releases)
- [Changelog](https://github.com/enzymejs/enzyme/blob/master/CHANGELOG.md)
- [Commits](https://github.com/airbnb/enzyme/commits/enzyme@3.11.0/packages/enzyme)

---
updated-dependencies:
- dependency-name: enzyme
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@dependabot @mmorel-35
Bump css-loader from 2.1.1 to 6.7.1
89ece96 
Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 2.1.1 to 6.7.1.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases)
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md)
- [Commits](webpack-contrib/css-loader@v2.1.1...v6.7.1)

---
updated-dependencies:
- dependency-name: css-loader
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@dependabot @mmorel-35
Bump eslint-config-prettier from 4.0.0 to 6.15.0
70520fa 
Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 4.0.0 to 6.15.0.
- [Release notes](https://github.com/prettier/eslint-config-prettier/releases)
- [Changelog](https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/eslint-config-prettier@v4.0.0...v6.15.0)

---
updated-dependencies:
- dependency-name: eslint-config-prettier
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@dependabot @mmorel-35
Bump prettier from 1.18.2 to 2.7.1
19c2570 
* Bump prettier from 1.18.2 to 2.7.1

Bumps [prettier](https://github.com/prettier/prettier) from 1.18.2 to 2.7.1.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@1.18.2...2.7.1)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update package.json

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update .eslintrc.js

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update run-commit.yml

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update run-commit.yml

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Commit from GitHub Actions (Run and commit)

* Update run-commit.yml

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Co-authored-by: mmorel-35 <mmorel-35@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@dependabot @mmorel-35
Bump url-loader from 1.1.2 to 4.1.1
07f0062 
Bumps [url-loader](https://github.com/webpack-contrib/url-loader) from 1.1.2 to 4.1.1.
- [Release notes](https://github.com/webpack-contrib/url-loader/releases)
- [Changelog](https://github.com/webpack-contrib/url-loader/blob/master/CHANGELOG.md)
- [Commits](webpack-contrib/url-loader@v1.1.2...v4.1.1)

---
updated-dependencies:
- dependency-name: url-loader
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@dependabot @mmorel-35
Bump combokeys from 3.0.0 to 3.0.1
66f9f20 
Bumps [combokeys](https://github.com/PolicyStat/combokeys) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/PolicyStat/combokeys/releases)
- [Commits](https://github.com/PolicyStat/combokeys/commits/v3.0.1)

---
updated-dependencies:
- dependency-name: combokeys
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@dependabot @mmorel-35
Bump rxjs-compat from 6.4.0 to 6.6.7
9460ed0 
Bumps rxjs-compat from 6.4.0 to 6.6.7.

---
updated-dependencies:
- dependency-name: rxjs-compat
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@dependabot @mmorel-35
Bump copy-to-clipboard from 3.1.0 to 3.3.2
02ee5b4 
Bumps [copy-to-clipboard](https://github.com/sudodoki/copy-to-clipboard) from 3.1.0 to 3.3.2.
- [Release notes](https://github.com/sudodoki/copy-to-clipboard/releases)
- [Commits](sudodoki/copy-to-clipboard@v3.1.0...v3.3.2)

---
updated-dependencies:
- dependency-name: copy-to-clipboard
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@dependabot @mmorel-35
Bump raven-js from 3.27.0 to 3.27.2
a03ba31 
Bumps [raven-js](https://github.com/getsentry/raven-js) from 3.27.0 to 3.27.2.
- [Release notes](https://github.com/getsentry/raven-js/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md)
- [Commits](https://github.com/getsentry/raven-js/compare/raven-js@3.27.0...v3.27.2)

---
updated-dependencies:
- dependency-name: raven-js
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@dependabot @mmorel-35
Bump cytoscape-dagre from 2.3.2 to 2.4.0
699bd2a 
Bumps [cytoscape-dagre](https://github.com/cytoscape/cytoscape.js-dagre) from 2.3.2 to 2.4.0.
- [Release notes](https://github.com/cytoscape/cytoscape.js-dagre/releases)
- [Commits](cytoscape/cytoscape.js-dagre@v2.3.2...v2.4.0)

---
updated-dependencies:
- dependency-name: cytoscape-dagre
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
Update dependabot.yml
eb638ef 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@dependabot @mmorel-35
Bump u-basscss from 2.0.0 to 2.0.1
c208386 
Bumps [u-basscss](https://github.com/tiffon/u-basscss) from 2.0.0 to 2.0.1.
- [Release notes](https://github.com/tiffon/u-basscss/releases)
- [Commits](https://github.com/tiffon/u-basscss/commits)

---
updated-dependencies:
- dependency-name: u-basscss
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@dependabot @mmorel-35
Bump react-helmet from 5.2.0 to 6.1.0
2899183 
* Bump react-helmet from 5.2.0 to 6.1.0

Bumps [react-helmet](https://github.com/nfl/react-helmet) from 5.2.0 to 6.1.0.
- [Release notes](https://github.com/nfl/react-helmet/releases)
- [Changelog](https://github.com/nfl/react-helmet/blob/master/CHANGELOG.md)
- [Commits](nfl/react-helmet@5.2.0...6.1.0)

---
updated-dependencies:
- dependency-name: react-helmet
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update run-commit.yml

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Commit from GitHub Actions (Run and commit)

* Update run-commit.yml

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Co-authored-by: mmorel-35 <mmorel-35@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
dependabot bot and others added 18 commits October 20, 2022 17:20
@dependabot @mmorel-35
Bump @types/recompose from 0.30.5 to 0.30.10
aa61a0e 
Bumps [@types/recompose](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/recompose) from 0.30.5 to 0.30.10.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/recompose)

---
updated-dependencies:
- dependency-name: "@types/recompose"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@dependabot @mmorel-35
Bump less from 3.9.0 to 3.13.1
ae6764f 
Bumps [less](https://github.com/less/less.js) from 3.9.0 to 3.13.1.
- [Release notes](https://github.com/less/less.js/releases)
- [Changelog](https://github.com/less/less.js/blob/master/CHANGELOG.md)
- [Commits](less/less.js@v3.9.0...v3.13.1)

---
updated-dependencies:
- dependency-name: less
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@dependabot @mmorel-35
Bump memoize-one from 5.1.1 to 6.0.0
db8ad5d 
Bumps [memoize-one](https://github.com/alexreardon/memoize-one) from 5.1.1 to 6.0.0.
- [Release notes](https://github.com/alexreardon/memoize-one/releases)
- [Commits](alexreardon/memoize-one@v5.1.1...v6.0.0)

---
updated-dependencies:
- dependency-name: memoize-one
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@dependabot @mmorel-35
Bump object-hash from 1.3.1 to 3.0.0
ce26c3b 
Bumps [object-hash](https://github.com/puleos/object-hash) from 1.3.1 to 3.0.0.
- [Release notes](https://github.com/puleos/object-hash/releases)
- [Commits](puleos/object-hash@v1.3.1...v3.0.0)

---
updated-dependencies:
- dependency-name: object-hash
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@dependabot @mmorel-35
Bump enzyme-to-json from 3.3.5 to 3.6.2
d9b9c52 
Bumps [enzyme-to-json](https://github.com/adriantoine/enzyme-to-json) from 3.3.5 to 3.6.2.
- [Release notes](https://github.com/adriantoine/enzyme-to-json/releases)
- [Changelog](https://github.com/adriantoine/enzyme-to-json/blob/master/CHANGELOG.md)
- [Commits](adriantoine/enzyme-to-json@v3.3.5...v3.6.2)

---
updated-dependencies:
- dependency-name: enzyme-to-json
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
Update dependabot.yml
efb13d2 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
Delete run-commit.yml
0fad3dc 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
Update dependabot.yml
569c65f 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@dependabot @mmorel-35
Bump @babel/core from 7.19.3 to 7.19.6
b837423 
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.19.3 to 7.19.6.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.19.6/packages/babel-core)

---
updated-dependencies:
- dependency-name: "@babel/core"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@dependabot @mmorel-35
Bump @types/memoize-one from 4.1.1 to 5.1.2
38b5980 
Bumps [@types/memoize-one](https://github.com/alexreardon/memoize-one) from 4.1.1 to 5.1.2.
- [Release notes](https://github.com/alexreardon/memoize-one/releases)
- [Commits](https://github.com/alexreardon/memoize-one/commits)

---
updated-dependencies:
- dependency-name: "@types/memoize-one"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@dependabot @mmorel-35
Bump @types/object-hash from 1.3.0 to 2.2.1
6648b89 
Bumps [@types/object-hash](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/object-hash) from 1.3.0 to 2.2.1.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/object-hash)

---
updated-dependencies:
- dependency-name: "@types/object-hash"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@dependabot @mmorel-35
Bump @types/deep-freeze from 0.1.1 to 0.1.2
2de4b5a 
Bumps [@types/deep-freeze](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/deep-freeze) from 0.1.1 to 0.1.2.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/deep-freeze)

---
updated-dependencies:
- dependency-name: "@types/deep-freeze"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@dependabot @mmorel-35
Bump @types/react-virtualized-select from 3.0.8 to 3.0.11
f945f6e 
Bumps [@types/react-virtualized-select](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-virtualized-select) from 3.0.8 to 3.0.11.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-virtualized-select)

---
updated-dependencies:
- dependency-name: "@types/react-virtualized-select"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@dependabot @mmorel-35
Bump webpack-dev-server from 3.2.1 to 3.11.3
2b50be1 
Bumps [webpack-dev-server](https://github.com/webpack/webpack-dev-server) from 3.2.1 to 3.11.3.
- [Release notes](https://github.com/webpack/webpack-dev-server/releases)
- [Changelog](https://github.com/webpack/webpack-dev-server/blob/v3.11.3/CHANGELOG.md)
- [Commits](webpack/webpack-dev-server@v3.2.1...v3.11.3)

---
updated-dependencies:
- dependency-name: webpack-dev-server
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
Update dependabot.yml
765d13b 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
prettier avoid arrowParens
7c428e9 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
rollback prettier to 1.18.2
801975b 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
tollback arrowParens override
18fd3fe 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@yurishkuro yurishkuro changed the title Upgrade all possible dependencies Upgrade many dependencies Oct 20, 2022
@yurishkuro
Copy link
Member

@mmorel-35 could you elaborate on your method of selecting the versions to upgrade to?

For example,

-    "eslint": "5.14.1",
+    "eslint": "5.16.0",

but the latest version is 5.40.1

@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Oct 20, 2022 •
edited
Loading

I suggest removing all pure styling changes. The PR is currently nearly impossible to review in GH Web UI, it crumbles. But more importantly, the styling changes obscure the real code changes that may have been necessary due to dependency upgrades. This is just a bad practice to combine such changes.

Ok, I just did it

I would like to understand the scope of the change. The title says "all deps", but I see that typescript version is still 3.x (dependabot has been trying to upgrade to 4.x for some time, there are some things that are breaking). And the other major one is react, which still seems to be at "react": "^16.3.2"

The title and description are not enoughly clear so let me try to explain. I tried to upgrade every possible dependencies except for the huge ones like webpack , react and typescript.
This is a preparation work so it becomes easier to deal with those big ones.

From what I have seen some dependencies like react-vis and react-vis-force are unmaintained and depend on old version of react so there is going to be a need to integrate it inside of jaeger of move to another project

I could also see that jaegertracing/plexus is a worker-loader which is deprecated in v5, see https://v4.webpack.js.org/loaders/worker-loader/
Jaeger ui is also relying on customize-cra which is depending on babel-plugin which is deprecated.

So there are several questions to address before being able to upgrade to latest versions of thoses big dependencies

@mmorel-35
Copy link
Contributor Author

@mmorel-35 could you elaborate on your method of selecting the versions to upgrade to?

For example,

-    "eslint": "5.14.1",
+    "eslint": "5.16.0",

but the latest version is 5.40.1

I just used dependabot on my own repository and that is the pr I received

@yurishkuro yurishkuro merged commit 7896ab5 into jaegertracing:main Oct 20, 2022
@yurishkuro
Copy link
Member

Thanks!

@aoterolorenzo aoterolorenzo mentioned this pull request Nov 9, 2022
Open
@yurishkuro yurishkuro mentioned this pull request Nov 12, 2022
Closed
This was referenced Nov 24, 2022
Closed
Merged
yurishkuro added a commit that referenced this pull request Nov 25, 2022
@yurishkuro
Revert upgrade to viz.js, v2.1.2 -> v1.8.1 (#1082)
b523881 
Resolves #1077.

The upgrade was introduced in #1001. Sadly, we have no unit tests in
`/plexus/` module, so the break was not caught.

In #1001 the dependency viz.js was upgraded to the next major version
(2.1.2), however it had breaking changes which were not accounted for.

Alternative paths tracked in #1081.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@everett980 everett980 Awaiting requested review from everett980

@rubenvp8510 rubenvp8510 Awaiting requested review from rubenvp8510

@tiffon tiffon Awaiting requested review from tiffon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmorel-35 @yurishkuro