Add View Option for raw/unadjusted trace #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <ys@uber.com>
yurishkuro
commented
Dec 23, 2017
| @@ -104,7 +104,12 @@ export default function TracePageHeader(props: TracePageHeaderProps) { | |||
| <Dropdown.Menu> | |||
| <Dropdown.Item> | |||
| <a rel="noopener noreferrer" target="_blank" href={`/api/traces/${traceID}`}> | |||
There was a problem hiding this comment.
@yurishkuro Yes, this needs the prefixUrl(...).
Also, is the trailing / in the raw version URL intentional?
/api/traces/${traceID}/?raw=true
Seems like the only difference should be the query string is appended?
/api/traces/${traceID}?raw=true
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
=======================================
Coverage 92.66% 92.66%
=======================================
Files 85 85
Lines 1881 1881
Branches 366 366
=======================================
Hits 1743 1743
Misses 126 126
Partials 12 12
Continue to review full report at Codecov.
|
|
add this to the change log so it can go out with 1.1? |
tiffon
suggested changes
Dec 23, 2017
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
|
@yurishkuro The I went ahead and added it (and fixed a failing unit test). |
tiffon
approved these changes
Dec 24, 2017
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
* Add View Option for raw/unadjusted trace Signed-off-by: Yuri Shkuro <ys@uber.com> * Remove / Signed-off-by: Yuri Shkuro <ys@uber.com> * Add missing prefixUrl adjustment Signed-off-by: Joe Farro <joef@uber.com> * Fix failing unit test Signed-off-by: Joe Farro <joef@uber.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
yurishkuro
pushed a commit
that referenced
this pull request
Nov 14, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [npm-run-all2](https://redirect.github.com/bcomnes/npm-run-all2) | [`6.2.2` -> `7.0.1`](https://renovatebot.com/diffs/npm/npm-run-all2/6.2.2/7.0.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>bcomnes/npm-run-all2 (npm-run-all2)</summary> ### [`v7.0.1`](https://redirect.github.com/bcomnes/npm-run-all2/blob/HEAD/CHANGELOG.md#v701) [Compare Source](https://redirect.github.com/bcomnes/npm-run-all2/compare/v7.0.0...v7.0.1) ##### Commits - Revert engine range bump back to Node 18 [`b2e849b`](https://redirect.github.com/bcomnes/npm-run-all2/commit/b2e849bf8d31135751dd7458724344dd1bca120e) ### [`v7.0.0`](https://redirect.github.com/bcomnes/npm-run-all2/blob/HEAD/CHANGELOG.md#v700---2024-10-21) [Compare Source](https://redirect.github.com/bcomnes/npm-run-all2/compare/v6.2.6...v7.0.0) ##### Merged - Prevent a throw when looking up undefined results [`#158`](https://redirect.github.com/bcomnes/npm-run-all2/pull/158) ##### Commits - **Breaking change:** Bump node engines ^18.17.0 || >=20.5.0 [`49b95f0`](https://redirect.github.com/bcomnes/npm-run-all2/commit/49b95f0c4905504a94d1a7ce87fbb7e77ab60df5) - Merge pull request [#​156](https://redirect.github.com/bcomnes/npm-run-all2/issues/156) from bcomnes/rm-rf-rimraf [`c661ffc`](https://redirect.github.com/bcomnes/npm-run-all2/commit/c661ffc942e09a68b1a553190d3a550dc0f6a39c) - Remove rimraf [`c77e085`](https://redirect.github.com/bcomnes/npm-run-all2/commit/c77e0856c65115b32788c3e9a1e441ba69fbd430) ### [`v6.2.6`](https://redirect.github.com/bcomnes/npm-run-all2/blob/HEAD/CHANGELOG.md#v626---2024-10-21) [Compare Source](https://redirect.github.com/bcomnes/npm-run-all2/compare/ee3bf122e700102b9ab27b1d172d98856765f4a4...v6.2.6) ##### Commits - Prevent a throw when looking up undefined results [`d928f9a`](https://redirect.github.com/bcomnes/npm-run-all2/commit/d928f9ad59c00a20797c90d35b62ef0aecf0c364) ### [`v6.2.5`](https://redirect.github.com/bcomnes/npm-run-all2/compare/v6.2.4...ee3bf122e700102b9ab27b1d172d98856765f4a4) [Compare Source](https://redirect.github.com/bcomnes/npm-run-all2/compare/v6.2.4...ee3bf122e700102b9ab27b1d172d98856765f4a4) ### [`v6.2.4`](https://redirect.github.com/bcomnes/npm-run-all2/blob/HEAD/CHANGELOG.md#v624) [Compare Source](https://redirect.github.com/bcomnes/npm-run-all2/compare/v6.2.3...v6.2.4) ##### Merged - Switch to JS-based `which` command [`#154`](https://redirect.github.com/bcomnes/npm-run-all2/pull/154) ##### Fixed - Switch to JS-based `which` command [`#153`](https://redirect.github.com/bcomnes/npm-run-all2/issues/153) ### [`v6.2.3`](https://redirect.github.com/bcomnes/npm-run-all2/blob/HEAD/CHANGELOG.md#v623) [Compare Source](https://redirect.github.com/bcomnes/npm-run-all2/compare/v6.2.2...v6.2.3) ##### Commits - Merge pull request [#​151](https://redirect.github.com/bcomnes/npm-run-all2/issues/151) from bcomnes/fix-pnpm-agian [`c43fa2b`](https://redirect.github.com/bcomnes/npm-run-all2/commit/c43fa2b677442c710a29654a333b15c8de4f00ab) - Avoid passing config fields as flags for pnpm [`dc2d7da`](https://redirect.github.com/bcomnes/npm-run-all2/commit/dc2d7da61cf0898d0bc2b25747e588325e06b9a9) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/jaegertracing/jaeger-ui). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xMS41IiwidXBkYXRlZEluVmVyIjoiMzkuMTEuNSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiY2hhbmdlbG9nOmRlcGVuZGVuY2llcyJdfQ==--> Signed-off-by: Mend Renovate <bot@renovateapp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #152