Exit mergeChildrenCriticalPath early for an empty critical path #1974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksim Gaponov <gaponovmaxev@gmail.com>
yurishkuro
previously approved these changes
Nov 13, 2023
yurishkuro
changed the title
yurishkuro
added
the
changelog:bugfix-or-minor-feature
yurishkuro
reviewed
Nov 13, 2023
| @@ -163,6 +163,9 @@ function mergeChildrenCriticalPath( | |||
| spanID: string, | |||
| criticalPath: criticalPathSection[] | |||
| ): criticalPathSection[] { | |||
| if (criticalPath.length == 0) { | |||
There was a problem hiding this comment.
linter complains
166:27 error Expected '===' and instead saw '=='
There was a problem hiding this comment.
couldn't this be just if (!criticalPath) ?
Codecov ReportAttention:
📢 Thoughts on this report? Let us know! |
Signed-off-by: Maksim Gaponov <gaponovmaxev@gmail.com>
auto-merge was automatically disabled
November 13, 2023 18:07
Head branch was pushed to by a user without write access
|
Do we need a test here to satisfy codecov? |
|
tests are always welcome, but from the outside of this function it seems it would be impossible to distinguish, since fully executing the logic still returns the same |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test