refactor: update LoadingIndicator component #2433
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Anyaele <gabrielanyaele21@gmail.com>
Ghaby-X
force-pushed
the
refactor/update-LoadingIndicator
branch
from
0f28d11
to
615253b
Compare
yurishkuro
reviewed
Sep 22, 2024
| @@ -159,7 +159,7 @@ export class UnconnectedDetailsPanel extends React.PureComponent<TProps, TState> | |||
| )} | |||
| {this.state.detailsLoading && ( | |||
| <div className="Ddg--DetailsPanel--LoadingWrapper"> | |||
| <LoadingIndicator className="Ddg--DetailsPanel--LoadingIndicator" /> | |||
| <LoadingIndicator centered={false} className="Ddg--DetailsPanel--LoadingIndicator" small={false} /> | |||
There was a problem hiding this comment.
false values are defaults, why do we need to set them explicitly?
There was a problem hiding this comment.
False values are indeed default. However, it seems there was a mismatch between the tests snapshot and the actual rendered component.
The snapshots explicitly included the false values even though it could be ignored, so I wrote the components to match them.
There was a problem hiding this comment.
I would rather update the snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This PR aims to ensure compatibility of the LoadingIndicator component with future React releases. The LoadingIndicator component was using the older defaultProps syntax, which will be removed in future React versions.
Description of the changes
The following changes have been made to the LoadingIndicator component:
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test