Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[query] Avoid errors when closing shared listener (#5559)
## Description This PR aims to address the intermittent timeout issue in the `TestServerSinglePort` test by adding enhanced logging to the `Start` and `Close` methods of the server. These additional logs provide better visibility into the server's behavior during the test, which should help in diagnosing the root cause of the issue. ## Changes ### Enhanced Logging: - Added error logging in the `Start` method for listener initialization failures. - Added info logging in the `Start` method to log the initialized HTTP and gRPC ports. - Added info logging in the `Close` method to indicate an attempt to close the server and confirm when the server has stopped. These changes provide better diagnostics and insights into server operations, which should help in identifying and resolving the flaky test issue if it occurs again. ## Related Issue Closes #5519 ## Checklist - [x] I have read `CONTRIBUTING_GUIDELINES` - [x] I have signed all commits - [ ] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Shivam Verma <vermaaatul07@gmail.com> Signed-off-by: Yuri Shkuro <github@ysh.us> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Co-authored-by: Yuri Shkuro <github@ysh.us>
- Loading branch information