Skip to content

Commit

Permalink
Add Go Leak Check for Badgerstore, gRPC and Memstore e2e Tests (#6347)
Browse files Browse the repository at this point in the history
## Which problem is this PR solving?
Fixes a part of #5006 

## Description of the changes
- Added go leak check for badgerstore, grpc and Memstore

## How was this change tested?
- Integration Tests

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

Signed-off-by: Manik2708 <mehtamanik96@gmail.com>
  • Loading branch information
Manik2708 authored Dec 12, 2024
1 parent d69dad5 commit 5b50428
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 0 deletions.
4 changes: 4 additions & 0 deletions plugin/storage/integration/badgerstore_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (
"go.uber.org/zap/zaptest"

"github.com/jaegertracing/jaeger/pkg/metrics"
"github.com/jaegertracing/jaeger/pkg/testutils"
"github.com/jaegertracing/jaeger/plugin/storage/badger"
)

Expand Down Expand Up @@ -47,6 +48,9 @@ func (s *BadgerIntegrationStorage) cleanUp(t *testing.T) {

func TestBadgerStorage(t *testing.T) {
SkipUnlessEnv(t, "badger")
t.Cleanup(func() {
testutils.VerifyGoLeaksOnce(t)
})
s := &BadgerIntegrationStorage{
StorageIntegration: StorageIntegration{
SkipArchiveTest: true,
Expand Down
4 changes: 4 additions & 0 deletions plugin/storage/integration/grpc_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import (

"github.com/jaegertracing/jaeger/pkg/config"
"github.com/jaegertracing/jaeger/pkg/metrics"
"github.com/jaegertracing/jaeger/pkg/testutils"
"github.com/jaegertracing/jaeger/plugin/storage/grpc"
)

Expand Down Expand Up @@ -61,6 +62,9 @@ func (s *GRPCStorageIntegrationTestSuite) cleanUp(t *testing.T) {

func TestGRPCRemoteStorage(t *testing.T) {
SkipUnlessEnv(t, "grpc")
t.Cleanup(func() {
testutils.VerifyGoLeaksOnce(t)
})
s := &GRPCStorageIntegrationTestSuite{
flags: []string{
"--grpc-storage.server=localhost:17271",
Expand Down
3 changes: 3 additions & 0 deletions plugin/storage/integration/memstore_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ func (s *MemStorageIntegrationTestSuite) initialize(_ *testing.T) {

func TestMemoryStorage(t *testing.T) {
SkipUnlessEnv(t, "memory")
t.Cleanup(func() {
testutils.VerifyGoLeaksOnce(t)
})
s := &MemStorageIntegrationTestSuite{}
s.initialize(t)
s.RunAll(t)
Expand Down

0 comments on commit 5b50428

Please sign in to comment.