comments

Signed-off-by: Yuri Shkuro <github@ysh.us>
jaegertracing · Jul 28, 2024 · c4b54ee · c4b54ee
1 parent 30ceb02
commit c4b54ee
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/cmd/jaeger/internal/integration/kafka_test.go b/cmd/jaeger/internal/integration/kafka_test.go
@@ -14,6 +14,11 @@ func TestKafkaStorage(t *testing.T) {
 
 	// TODO these config files use topic: "jaeger-spans",
 	// but for integration tests we want to use random topic in each run.
+	// https://github.com/jaegertracing/jaeger/blob/ed5cc2981c34158d0650cb96cb2fafcb753bea70/plugin/storage/integration/kafka_test.go#L50-L51
+	// Once OTEL Collector supports default values for env vars
+	// (https://github.com/open-telemetry/opentelemetry-collector/issues/5228)
+	// we can change the config to use topic: "${KAFKA_TOPIC:-jaeger-spans}"
+	// and export a KAFKA_TOPIC var with random topic name in the tests.
 
 	collectorConfig := "../../collector-with-kafka.yaml"
 	ingesterConfig := "../../ingester-remote-storage.yaml"