Skip to content

Commit

Permalink
Fix proto version (#2975)
Browse files Browse the repository at this point in the history
Signed-off-by: albertteoh <albert.teoh@logz.io>
  • Loading branch information
albertteoh authored May 3, 2021
1 parent 870fc90 commit e13f0fe
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion model/proto/metrics/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ in compilation errors from the generated code as opentelemetry-proto's Metric ty
gogoproto.marshaler_all, gogoproto.unmarshaler_all, etc. enabled.

Moreover, if direct imports of other repositories were possible, it would mean importing and generating code for
transitive dependencies not required by Jaeger leading to longer build times, and potentially larger docker
transitive dependencies not required by Jaeger leading to longer build times, and potentially larger container
image sizes.

Given the aforementioned limitations, selectively copying necessary messages and enums allow for:
Expand Down
2 changes: 1 addition & 1 deletion model/proto/metrics/otelmetric.proto
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// Based on: https://github.com/open-telemetry/opentelemetry-proto/blob/main/opentelemetry/proto/metrics/v1/metrics.proto
// Based on: https://github.com/open-telemetry/opentelemetry-proto/blob/v0.8.0/opentelemetry/proto/metrics/v1/metrics.proto

syntax="proto3";

Expand Down
2 changes: 1 addition & 1 deletion model/proto/metrics/otelspankind.proto
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// Based on: https://github.com/open-telemetry/opentelemetry-proto/blob/main/opentelemetry/proto/trace/v1/trace.proto
// Based on: https://github.com/open-telemetry/opentelemetry-proto/blob/v0.8.0/opentelemetry/proto/trace/v1/trace.proto

syntax="proto3";

Expand Down

0 comments on commit e13f0fe

Please sign in to comment.