Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on sarama-cluster (Kafka driver) #1052

Closed
yurishkuro opened this issue Sep 5, 2018 · 8 comments
Closed

Remove dependency on sarama-cluster (Kafka driver) #1052

yurishkuro opened this issue Sep 5, 2018 · 8 comments

Comments

@yurishkuro
Copy link
Member

@yurishkuro
Copy link
Member Author

Transferring #1090 by @vprithvi here:

Use high level consumer groups from IBM/sarama#1099 instead of sarama-cluster.
This is a rewrite of high level consumer functionality and can side step the issues described in #1052

@yurishkuro yurishkuro changed the title Issues with Kafka driver (sarama-cluster) Remove dependency on sarama-cluster (Kafka driver) due to instability Oct 6, 2018
@yurishkuro yurishkuro changed the title Remove dependency on sarama-cluster (Kafka driver) due to instability Remove dependency on sarama-cluster (Kafka driver) Oct 6, 2018
@marqc
Copy link
Contributor

marqc commented Oct 19, 2018

Instead of sarama You can take a look at https://github.com/confluentinc/confluent-kafka-go
It's a light wrapper for C implementation of kafka client (librdkafka) and AFAIK is more stable/reliable than shopify/sarama.

@vprithvi
Copy link
Contributor

vprithvi commented Nov 1, 2018

@marqc Thanks for the suggestion - we haven't yet explored it because we weren't familiar with how the build and deployment process changes when depending on a native bindings.

@yurishkuro
Copy link
Member Author

My vote is against libraries that depend on native bindings. Not only do they complicate the build in CI, they increase the barrier to entry for new contributors.

@isaachier
Copy link
Contributor

Ironically, given my C++ background, I happen to agree. Also, go get is completely useless for any Go package using non-Go build dependencies.

@ledor473
Copy link
Member

ledor473 commented Nov 5, 2018

👍 on not using the C wrapper.

We used it in a project internally and had a hard time making it work on older kernel (especially having a statically-linked binary)

@clock21am
Copy link
Contributor

is anyone working on this issue, i have bit experience working with Kafka and sarama can take this task if this is okay ?

@abhishek-j16
Copy link

Is anyone actively working on this? We still see the issue with Jaeger version 1.56(latest as of today).

We see that rebalancing is not trigerred upon change in partitions, eventually causing data loss.

@yurishkuro yurishkuro closed this as not planned Won't fix, can't repro, duplicate, stale Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants