Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showing latest traces not working properly using all-in-one with badger #1913

Closed
flixr opened this issue Nov 9, 2019 · 3 comments · Fixed by #1939
Closed

showing latest traces not working properly using all-in-one with badger #1913

flixr opened this issue Nov 9, 2019 · 3 comments · Fixed by #1939
Labels
bug storage/badger Issues related to badger storage

Comments

@flixr
Copy link

flixr commented Nov 9, 2019

Requirement - what kind of business use case are you trying to solve?

Seeing the latest traces while limiting the number of results.

Problem - what in Jaeger blocks you from solving the requirement?

With all-in-one 1.15.1 I don't get the latest X traces anymore, but it seems rather the traces with highest trace ID first.
With 1.14 I correctly get the latest X number of traces, regardless of their trace id.

Running jaeger/all-in-one via docker:

jaeger:
    image: jaegertracing/all-in-one:1.15.1
    environment:
      - "COLLECTOR_ZIPKIN_HTTP_PORT=9411"
      - "SPAN_STORAGE_TYPE=badger"
      - "BADGER_EPHEMERAL=false"
      - "BADGER_DIRECTORY_VALUE=/badger/data"
      - "BADGER_DIRECTORY_KEY=/badger/key"
    volumes:
      - jaeger-storage:/badger
    expose:
      - "9411"
      - "16686"
    ports:
      - "16686:16686"

Just changing back to 1.14 shows me the latest (e.g. 20) traces again.

Proposal - what do you suggest to solve the problem or improve the existing situation?

It seems like the search is now giving back the first X number of traces in the given time range based on the highest traceID instead of latest time.
The behavior in 1.14 was correctly returning the latest traces first.

Any open questions to address

@burmanm
Copy link
Contributor

burmanm commented Nov 9, 2019

Yep, this limit ordering was broken by the PR #1809

@yurishkuro
Copy link
Member

@burmanm is this a bug that needs to be fixed?

@pavolloffay pavolloffay added storage/badger Issues related to badger storage bug labels Nov 11, 2019
@flixr
Copy link
Author

flixr commented Nov 13, 2019

For us this bug makes jaeger even less usable than without a working tag search, so we had to go back to 1.14 until this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug storage/badger Issues related to badger storage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants