Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support url for sampling.strategies file #2015

Closed
trondhindenes opened this issue Jan 14, 2020 · 4 comments · Fixed by #2519
Closed

Support url for sampling.strategies file #2015

trondhindenes opened this issue Jan 14, 2020 · 4 comments · Fixed by #2519
Labels
changelog:new-feature Change that should be called out as new feature in CHANGELOG enhancement good first issue Good for beginners

Comments

@trondhindenes
Copy link

trondhindenes commented Jan 14, 2020

Requirement - what kind of business use case are you trying to solve?

We'd like to allow dev teams to control sampling strategies. This currently is quite involved since jaeger relies on a filesystem-file. In kubernetes this typically means a configMap volume, which requires us to restart all jaeger collector pods when the file is updated. Quite cumbersome.

I'd like Jaeger to support a sampling.strategies.url option, where the sampling strategies file was downloaded from a url. The cache timeout could be a separate parameter, or it could use the cache headers from the dowload to determine how often to retrieve updates.

Imho this would allow much easier changing of the sampling strategies, as we would be able to build a super-simple rest api to provide the json payload.

Problem - what in Jaeger blocks you from solving the requirement?

strategies.json is implemented as a filesystem-file only

Proposal - what do you suggest to solve the problem or improve the existing situation?

See requirement secion

Any open questions to address

@ghost ghost added the needs-triage label Jan 14, 2020
@jpkrohling jpkrohling added changelog:new-feature Change that should be called out as new feature in CHANGELOG enhancement good first issue Good for beginners hacktoberfest and removed needs-triage labels Sep 10, 2020
@jpkrohling
Copy link
Contributor

Looks interesting, do you want to give it a try?

@trondhindenes
Copy link
Author

i'm not a go dev unfortunately, so implementing this is a bit out of reach for me atm.

@goku321
Copy link
Contributor

goku321 commented Sep 20, 2020

Would like to try my hands on this.

@jpkrohling
Copy link
Contributor

Go for it!

goku321 added a commit to goku321/jaeger that referenced this issue Sep 29, 2020
This adds an option to support downloading sampling
strategies file from a URL in JSON format.

Fixes jaegertracing#2015

Signed-off-by: Deepak Sah <sah.sslpu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:new-feature Change that should be called out as new feature in CHANGELOG enhancement good first issue Good for beginners
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants