Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the use of "esc" with standard "embed" package #2749

Closed
6 tasks done
yurishkuro opened this issue Jan 29, 2021 · 3 comments · Fixed by #3399
Closed
6 tasks done

Replace the use of "esc" with standard "embed" package #2749

yurishkuro opened this issue Jan 29, 2021 · 3 comments · Fixed by #3399
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@yurishkuro
Copy link
Member

yurishkuro commented Jan 29, 2021 •
edited
Loading

We're currently using github.com/mjibson/esc to embed certain files (like UI assets) into binaries.

Upcoming Go 1.16 supports this with a new standard package embed and //go:embed directive.

See also: #2748
@yurishkuro yurishkuro added help wanted Features that maintainers are willing to accept but do not have cycles to implement good first issue Good for beginners labels Jan 29, 2021
@yurishkuro
Copy link
Member Author

A blog post that might be useful (I did not read it yet): https://lakefs.io/working-with-embed-in-go/

@srikanthccv
Copy link
Contributor

@yurishkuro I would like to work on this.

@yurishkuro
Copy link
Member Author

+1

This was referenced Feb 25, 2021
Merged
Merged
Merged
Closed
@yurishkuro yurishkuro changed the title Replace the use of 3rd party embedding libs with stdlib's embed package (in Go 1.16) Replace the use "esc" with stdlib's "embed" package Feb 26, 2021
@yurishkuro yurishkuro changed the title Replace the use "esc" with stdlib's "embed" package Replace the use "esc" with standard "embed" package Feb 26, 2021
@jpkrohling jpkrohling mentioned this issue Aug 24, 2021
Closed
@yurishkuro yurishkuro changed the title Replace the use "esc" with standard "embed" package Replace the use of "esc" with standard "embed" package Oct 5, 2021
@Ashmita152 Ashmita152 mentioned this issue Nov 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add adapter that implements http.FileSystem for reading gzip files Ashmita152/jaeger
2 participants
@yurishkuro @srikanthccv