-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support embedding assets from a subdir #2846
Support embedding assets from a subdir #2846
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2846 +/- ##
==========================================
+ Coverage 95.94% 95.96% +0.02%
==========================================
Files 221 222 +1
Lines 9689 9696 +7
==========================================
+ Hits 9296 9305 +9
+ Misses 324 323 -1
+ Partials 69 68 -1
Continue to review full report at Codecov.
|
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
ba4bdef
to
74217d4
Compare
@albertteoh fix for that nested dir |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! Looking forward to removing use of esc
altogether; I noticed it's been a common question/problem from folks trying to run/build the backend components because they haven't installed it or $GOPATH
isn't in their $PATH
.
Indeed. And the gen_assets kept being regenerated with only difference being the timestamp, pretty annoying. We need to merge #2822 before the last esc piece can be removed. |
Part of #2749.
http.FileSystem
behavioresc
with embedding for the main UI placeholder