Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: HotRod example fails documented kustomize build #4230

Closed
bigfleet opened this issue Feb 10, 2023 · 5 comments · Fixed by #4234
Closed

[Bug]: HotRod example fails documented kustomize build #4230

bigfleet opened this issue Feb 10, 2023 · 5 comments · Fixed by #4234
Labels

Comments

@bigfleet
Copy link
Contributor

bigfleet commented Feb 10, 2023

What happened?

As a Jaeger newbie
I want to see how to run an example app on Kubernetes
So that I can see how traffic flows from an application to sidecar to jaeger collector with or without OpenTelemetry

Steps to reproduce

  1. Download this reposmain branch
  2. Access the hotrod example at examples/hotrod
  3. Reference the "run on kubernetes section"
  4. Run kustomize build ./kubernetes | kubectl apply -f -

Expected behavior

I expected kustomize build to create YAML resources and for kubectl apply to apply them.

Relevant log output

examples/hotrod/main > kustomize build ./kubernetes | kubectl apply -f -
Error: accumulating resources: accumulation err='accumulating resources from 'base/jaeger': evalsymlink failure on '/Users/jvanfleet/src/nano/jaeger/examples/hotrod/kubernetes/base/jaeger' : lstat /Users/jvanfleet/src/nano/jaeger/examples/hotrod/kubernetes/base/jaeger: no such file or directory': must build at directory: not a valid directory: evalsymlink failure on '/Users/jvanfleet/src/nano/jaeger/examples/hotrod/kubernetes/base/jaeger' : lstat /Users/jvanfleet/src/nano/jaeger/examples/hotrod/kubernetes/base/jaeger: no such file or directory
error: no objects passed to apply

Screenshot

No response

Additional context

It does appear that the kustomization once targeted a jaeger directory, and now there is a jaeger-all-in-one -- that change to kustomization.yaml is not enough, though:

examples/hotrod/main ☣> kustomize build ./kubernetes | kubectl apply -f -
Error: accumulating resources: accumulation err='accumulating resources from 'base/jaeger-all-in-one': '/Users/jvanfleet/src/nano/jaeger/examples/hotrod/kubernetes/base/jaeger-all-in-one' must resolve to a file': recursed merging from path '/Users/jvanfleet/src/nano/jaeger/examples/hotrod/kubernetes/base/jaeger-all-in-one': may not add resource with an already registered id: Deployment.v1.apps/example-hotrod.[noNs]

I would help, but I am trying to learn myself! I appreciate there's a lot of attention on docker, but hopefully there are some cycles for learning on the cluster.

Jaeger backend version

v1.42

SDK

Whatever hotrod is using, hopefully.

Pipeline

I would like to ultimately monitor what the sidecar injection does without any other influence to determine if that's possible for my use case.

Stogage backend

Memory

Operating system

n/a

Deployment model

Kuberntes

Deployment configs

All contained in the repo
@bigfleet bigfleet added the bug label Feb 10, 2023
@bigfleet
Copy link
Contributor Author

Changing the kustomization to jaeger-all-in-one and leaving hotrod commented out DOES work, however, so this could be a simple PR. I can do it, if that makes sense. (No idea about contributor agreements, etc.)

@yurishkuro
Copy link
Member

cc @highb

@highb
Copy link
Contributor

highb commented Feb 11, 2023

@bigfleet I'll add this to my backlog or, if you want to open a PR to fix it, I can review.

@bigfleet
Copy link
Contributor Author

@highb ready to review

yurishkuro pushed a commit that referenced this issue Feb 13, 2023
Signed-off-by: Jim Van Fleet <jim@jimvanfleet.com>

## Which problem is this PR solving?
- Resolves #4230 

## Short description of the changes
- Updating the document to include the updated all-in-one path
- Adding one additional comment for those not briefed on kustomize

Signed-off-by: Jim Van Fleet <jim@jimvanfleet.com>
@highb
Copy link
Contributor

highb commented Feb 17, 2023

Thanks for reviewing it @yurishkuro ! It's been a busy week for me. 😮‍💨

shubbham1215 pushed a commit to shubbham1215/jaeger that referenced this issue Feb 22, 2023
Signed-off-by: Jim Van Fleet <jim@jimvanfleet.com>

## Which problem is this PR solving?
- Resolves jaegertracing#4230 

## Short description of the changes
- Updating the document to include the updated all-in-one path
- Adding one additional comment for those not briefed on kustomize

Signed-off-by: Jim Van Fleet <jim@jimvanfleet.com>
shubbham1215 pushed a commit to shubbham1215/jaeger that referenced this issue Mar 5, 2023
Signed-off-by: Jim Van Fleet <jim@jimvanfleet.com>

## Which problem is this PR solving?
- Resolves jaegertracing#4230

## Short description of the changes
- Updating the document to include the updated all-in-one path
- Adding one additional comment for those not briefed on kustomize

Signed-off-by: Jim Van Fleet <jim@jimvanfleet.com>
Signed-off-by: shubbham1215 <sawaikershubham@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants