Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement adjusters to operate on OTLP data format #6344

Open
1 of 8 tasks
mahadzaryab1 opened this issue Dec 12, 2024 · 0 comments
Open
1 of 8 tasks

Implement adjusters to operate on OTLP data format #6344

mahadzaryab1 opened this issue Dec 12, 2024 · 0 comments

Comments

@mahadzaryab1
Copy link
Collaborator

mahadzaryab1 commented Dec 12, 2024

Today, we have adjusters in model/adjuster that perform modifications to a trace object. We want to implement v2 versions of all these adjusters that operate directly on the OTLP data format (ptrace.traces instead of on model.Trace).

@mahadzaryab1 mahadzaryab1 self-assigned this Dec 12, 2024
yurishkuro pushed a commit that referenced this issue Dec 12, 2024
…#6346)

## Which problem is this PR solving?
- Towards #6344

## Description of the changes
- This PR adds an interface for `Adjuster` to operate on the OTLP model
format so that it can be used by the v2 query service. The v1
interface/implementation can be found in `model/adjuster`.
- In the following PRs, we'll implement all the standard adjusters in
`model/adjuster` to implement the new interface.

## How was this change tested?
- Unit tests

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---------

Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
mahadzaryab1 added a commit that referenced this issue Dec 13, 2024
…del (#6354)

## Which problem is this PR solving?
- Towards #6344 

## Description of the changes
- This PR implements the `SpanReferences` adjuster to operate on the
OTLP data model. In the OTLP model, references are dubbed as links so
the adjuster was renamed to `SpanLinks`

## How was this change tested?
- Added unit tests

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant